From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v4 12/12] test: Move video processing files to $STATEBASE
Date: Sat, 10 Sep 2022 22:41:19 +0200
Message-ID: <20220910224119.1f0ab9c6@elisabeth>
In-Reply-To: <YxxArKSldcnKQ7WQ@yekko>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2241301687764228955=="

--===============2241301687764228955==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 10 Sep 2022 17:45:48 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Fri, Sep 09, 2022 at 05:00:35PM +0200, Stefano Brivio wrote:
> > On Fri,  9 Sep 2022 13:30:28 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >  =20
> > > The asciinema video handling creates a number of temporary files (.unca=
t,
> > > .start, .stop) which currently go into the source tree.  Put them in the
> > > temporary state directory to avoid clutter.  Put the final processed vi=
deo
> > > into the test_logs/ directory, since it's essentially a test output
> > > artefact. =20
> >=20
> > This needs an update in hooks/pre-push in any case, but... I wouldn't =20
>=20
> Uh.. right.  The hooks aren't part of the repo contents, though, so I
> can't change that.

They are, in some sense:

  $ git log --oneline -1 hooks/pre-push
  ba72c83 hooks: Copy .webp diagram versions too

I then copy that single hook to .git whenever I clone a repository, as
suggested in the comment:

  $ grep .git hooks/pre-push
  # cp hooks/pre-push .git/hooks/pre-push

...this should eventually become a server-side post-receive hook, I
guess, using a temporary branch for testing and then forwarding the
updates to master if the tests pass.

But I haven't looked yet into headless asciinema captures -- I guess
it's doable and I've been doing something similar with Xvfb, it might
need some extra setup in the test scripts though.

> > mix those. The current directory listing at:
> >   https://passt.top/builds/latest/test/
> >=20
> > is sort of usable right now, and if I just scp everything into there,
> > it wouldn't be anymore.
> >=20
> > Maybe we could move the cast files to test_logs/web/, then scp:
> >=20
> > - test_logs/* (files only) to latest/test/
> > - test_logs/web/* to latest/web/
> >=20
> > instead? =20
>=20
> Sure, we could do that.  It's really up to you what you want the
> workflow to be.

Hmm, yes, that would be my preferred option at the moment. I can also
take care of updating the hook when I apply your patches.

--=20
Stefano


--===============2241301687764228955==--