From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 05/10] Move self-isolation code into a separate file
Date: Sat, 10 Sep 2022 22:43:12 +0200
Message-ID: <20220910224304.6c94204e@elisabeth>
In-Reply-To: <Yxw7jJ6Z7oTnviEL@yekko>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4100451494830382512=="

--===============4100451494830382512==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 10 Sep 2022 17:23:56 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Fri, Sep 09, 2022 at 04:33:58PM +0200, Stefano Brivio wrote:
> > On Thu,  8 Sep 2022 13:59:02 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >  =20
> > > [...]
> > >
> > > +++ b/isolation.c
> > >
> > > [...]
> > >
> > > +/**
> > > + * sandbox() - Unshare IPC, mount, PID, UTS, and user namespaces, "unm=
ount" root
> > > + *
> > > + * Return: negative error code on failure, zero on success
> > > + */
> > > +int sandbox(struct ctx *c) =20
> >=20
> > Same here, I would "document" "c". =20
>=20
> Not in scope for this patch, since it's a pure code motion.

Whoops, my bad, I didn't notice.

--=20
Stefano


--===============4100451494830382512==--