From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH v3 08/11] test: Extend context system to run commands in namespace for pasta tests Date: Mon, 12 Sep 2022 20:56:21 +1000 Message-ID: <20220912105624.969382-9-david@gibson.dropbear.id.au> In-Reply-To: <20220912105624.969382-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5467290905876071262==" --===============5467290905876071262== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Extend the context system to allow commands to be run in a namespace created with unshare, and use it for the namespace used in the pasta tests. Signed-off-by: David Gibson --- test/lib/context | 21 ++++++++++++++++++++- test/lib/layout | 4 +--- test/lib/setup | 17 ++++++++--------- 3 files changed, 29 insertions(+), 13 deletions(-) diff --git a/test/lib/context b/test/lib/context index babf59a..0d92d8f 100644 --- a/test/lib/context +++ b/test/lib/context @@ -13,13 +13,32 @@ # Copyright Red Hat # Author: David Gibson =20 +# context_setup_common() - Create outline of a new context +# $1: Context name +context_setup_common() { + __name=3D"$1" + __prefix=3D"${LOGDIR}/context_${__name}" + echo -n "${__name}$ " > "${__prefix}.log" +} + # context_setup_host() - Create a new context for running commands on the ho= st # $1: Context name context_setup_host() { __name=3D"$1" __prefix=3D"${LOGDIR}/context_${__name}" + context_setup_common "${__name}" echo sh -c > "${__prefix}.enter" - echo -n "${__name}$ " > "${__prefix}.log" +} + +# context_setup_nsenter() - Create a new context for running commands in a n= amespace +# $1: Context name +# $2: Namespace PID +context_setup_nsenter() { + __name=3D"$1" + shift + __prefix=3D"${LOGDIR}/context_${__name}" + context_setup_common "${__name}" + echo "nsenter $@ sh -c" > "${__prefix}.enter" } =20 # context_teardown() - Remove a context (leave log files intact) diff --git a/test/lib/layout b/test/lib/layout index 95bd035..1401955 100644 --- a/test/lib/layout +++ b/test/lib/layout @@ -61,15 +61,13 @@ layout_pasta() { =20 get_info_cols =20 - tmux pipe-pane -O -t ${PANE_NS} "cat >> ${LOGDIR}/pane_ns.log" - tmux select-pane -t ${PANE_NS} -T "namespace" - tmux send-keys -l -t ${PANE_INFO} 'while cat /tmp/.passt_test_log_pipe; do = :; done' tmux send-keys -t ${PANE_INFO} -N 100 C-m tmux select-pane -t ${PANE_INFO} -T "test log" =20 pane_watch_contexts ${PANE_HOST} host host pane_watch_contexts ${PANE_PASST} pasta passt + pane_watch_contexts ${PANE_NS} "namespace" unshare ns =20 info_layout "single pasta instance with namespace" =20 diff --git a/test/lib/setup b/test/lib/setup index 6598422..a87bce9 100755 --- a/test/lib/setup +++ b/test/lib/setup @@ -17,6 +17,7 @@ INITRAMFS=3D"${BASEPATH}/mbuto.img" VCPUS=3D"$( [ $(nproc) -ge 8 ] && echo 6 || echo $(( $(nproc) / 2 + 1 )) )" __mem_kib=3D"$(sed -n 's/MemTotal:[ ]*\([0-9]*\) kB/\1/p' /proc/meminfo)" VMEM=3D"$((${__mem_kib} / 1024 / 4))" +NSHOLDER=3D"${BASEPATH}/nsholder" =20 # setup_build() - Set up pane layout for build tests setup_build() { @@ -72,17 +73,14 @@ setup_passt() { setup_pasta() { context_setup_host host context_setup_host passt + context_setup_host unshare =20 layout_pasta =20 - pane_run NS 'echo $$' - pane_wait NS - __tty_pid=3D"$(pane_parse NS)" - - pane_run NS "unshare -rUnpf /bin/sh" - pane_status NS + context_run_bg unshare "unshare -rUnpf ${NSHOLDER} ns.hold hold" + __target_pid=3D$(${NSHOLDER} ns.hold pid) =20 - __target_pid=3D$(pstree -p ${__tty_pid} | sed -n 's/.*(\([0-9].*\))$/\1/p') + context_setup_nsenter ns -U -n -p --preserve-credentials -t ${__target_pid} =20 # Ports: # @@ -318,11 +316,12 @@ teardown_passt() { =20 # teardown_passt() - Exit namespace, kill pasta process teardown_pasta() { - tmux send-keys -t ${PANE_NS} "C-d" - pane_wait NS + ${NSHOLDER} ns.hold stop + context_wait unshare =20 teardown_context_watch ${PANE_HOST} host teardown_context_watch ${PANE_PASST} passt + teardown_context_watch ${PANE_NS} unshare ns } =20 # teardown_passt_in_ns() - Exit namespace, kill qemu and pasta, remove pid f= ile --=20 2.37.3 --===============5467290905876071262==--