public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] doc/demo: Drop /sbin from dhclient command, pass script file explicitly
Date: Sat, 17 Sep 2022 10:44:31 +0200	[thread overview]
Message-ID: <20220917104431.0b825fdc@elisabeth> (raw)
In-Reply-To: <YyU9y47EeJs8uqFk@yekko>

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On Sat, 17 Sep 2022 13:23:55 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Sat, Sep 17, 2022 at 01:55:18AM +0200, Stefano Brivio wrote:
> > dhclient might be in /usr/sbin on recent versions of Fedora, and
> > mbuto just adds it to the same location as it was on the host:
> > just call dhclient instead of /sbin/dhclient.
> > 
> > This also applies for dhclient-script: given that we create the file
> > on boot, pass its explicit location with -sf.
> > 
> > Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>  
> 
> Hm, for the tests mbuto image I addressed this with symlinks instead.
> Not sure which is more elegant.

Yes, I noticed... I think the symlinks are actually more elegant, but
this is meant for interactive usage, and that has some potential to
confuse the user.

-- 
Stefano


  reply	other threads:[~2022-09-17  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 23:55 [PATCH 0/2] doc/demo: Fix two issues seen on Fedora 36 Stefano Brivio
2022-09-16 23:55 ` [PATCH 1/2] doc/demo: Drop /sbin from dhclient command, pass script file explicitly Stefano Brivio
2022-09-17  3:23   ` David Gibson
2022-09-17  8:44     ` Stefano Brivio [this message]
2022-09-17  9:50       ` David Gibson
2022-09-16 23:55 ` [PATCH 2/2] doc/demo: Clone and use mbuto in init namespace Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220917104431.0b825fdc@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).