From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH 6/7] test/lib: Wait on iperf3 clients to be done, then send SIGINT to servers Date: Wed, 21 Sep 2022 22:55:06 +0200 Message-ID: <20220921205507.2742203-7-sbrivio@redhat.com> In-Reply-To: <20220921205507.2742203-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3167247083047556639==" --===============3167247083047556639== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit An iperf3 client might fail to send the control message indicating the end of the test, if the kernel buffer doesn't accept it, and exit without having sent it, as the control socket is non-blocking. Should this happen, the server will just wait forever for this message, instead of terminating. Restore some of the behaviour that went away with the "test: Rewrite test_iperf3" patch: instead of waiting on servers to terminate, wait on the clients. When they are done, wait 2 seconds, and then send SIGINT to the servers, which make them still write out the JSON report before terminating. Signed-off-by: Stefano Brivio --- test/lib/test | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/lib/test b/test/lib/test index a9ffe83..b69d519 100755 --- a/test/lib/test +++ b/test/lib/test @@ -32,13 +32,11 @@ test_iperf3() { __time="${1}"; shift pane_or_context_run_bg "${__sctx}" \ - '(' \ - ' for i in $(seq 0 '${__procs}'); do' \ - ' iperf3 -s1J -p'${__port}' -i'${__time} \ - ' > s${i}.json &' \ - ' done;' \ - ' wait' \ - ')' + 'for i in $(seq 0 '${__procs}'); do' \ + ' (iperf3 -s1J -p'${__port}' -i'${__time} \ + ' > s${i}.json) &' \ + ' echo $! > s${i}.pid &' \ + 'done' \ sleep 1 # Wait for server to be ready @@ -51,7 +49,9 @@ test_iperf3() { ' wait' \ ')' - pane_or_context_wait "${__sctx}" + # If client fails to deliver control message, tell server we're done + pane_or_context_run "${__sctx}" \ + 'sleep 2; kill -INT $(cat s*.pid); rm s*.pid' __jval=".end.sum_received.bits_per_second" for __opt in ${@}; do -- 2.35.1 --===============3167247083047556639==--