From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 4/7] conf, tcp, udp: Arrays for ports need 2^16 values, not 2^16-8 Date: Fri, 23 Sep 2022 01:39:47 +0200 Message-ID: <20220923013947.0176581f@elisabeth> In-Reply-To: <20220922102150.3c57471c@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5871655490732549674==" --===============5871655490732549674== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Thu, 22 Sep 2022 10:21:50 +0200 Stefano Brivio wrote: > On Thu, 22 Sep 2022 16:43:24 +1000 > David Gibson wrote: > > [...] > > > I have a series which makes a number of cleanups to the port mapping > > handling. It fixes this bug and adds typing stuff that should make it > > harder to make similar mistakes in future. > > > > I held off on sending, since it's currently based on a lot of my > > outstanding patches. I think it wouldn't be too hard to rebase > > directly on master, should I do that so you can fix this before going > > on to debug the rest of my outstanding stuff? > > If it's not too much effort for you, yes, that would be appreciated. > > I hope to be able to push out everything else later today, it's just > one glitch still occurring in test_iperf3() -- sometimes, clients and > servers terminate properly, but we don't see it for some reason. Actually, it looks like I got tests finally passing, and I should be pushing all the pending patches soon... perhaps you could wait before you rebase, I guess it's more convenient. -- Stefano --===============5871655490732549674==--