public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH 01/12] test: Add wait_for() shell helper
Date: Fri, 23 Sep 2022 17:20:27 +1000	[thread overview]
Message-ID: <20220923072038.1667106-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20220923072038.1667106-1-david@gibson.dropbear.id.au>

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Add a shell helper function to wait for some command to succeed - typically
a test for something to be done by a background process.  Use it in the
context code which waits for the guest to respond to ssh-over-vsock
connections.

Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
 test/lib/context | 4 +---
 test/lib/util    | 8 ++++++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/test/lib/context b/test/lib/context
index 43b00dd..ee6b683 100644
--- a/test/lib/context
+++ b/test/lib/context
@@ -63,9 +63,7 @@ EOF
 	echo "ssh -F ${__ssh} ${__name}" > "${__enter}"
 
 	# Wait for the guest to be booted and accepting connections
-	while ! ssh -F "${__ssh}" "${__name}" :; do
-		sleep 0.1
-	done
+	wait_for ssh -F "${__ssh}" "${__name}" :
 }
 
 # context_teardown() - Remove a context (leave log files intact)
diff --git a/test/lib/util b/test/lib/util
index dee6c8d..72023ab 100755
--- a/test/lib/util
+++ b/test/lib/util
@@ -123,3 +123,11 @@ get_info_cols() {
 		__j=$((__j + 1))
 	done
 }
+
+# wait_for() - Retry a command until it succeeds
+# $@:	Command to run
+wait_for() {
+        while ! "$@"; do
+                sleep 0.1
+        done
+}
-- 
@@ -123,3 +123,11 @@ get_info_cols() {
 		__j=$((__j + 1))
 	done
 }
+
+# wait_for() - Retry a command until it succeeds
+# $@:	Command to run
+wait_for() {
+        while ! "$@"; do
+                sleep 0.1
+        done
+}
-- 
2.37.3


  reply	other threads:[~2022-09-23  7:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  7:20 [PATCH 00/12] Assorted test fixes, batch 7 David Gibson
2022-09-23  7:20 ` David Gibson [this message]
2022-09-23 23:07   ` [PATCH 01/12] test: Add wait_for() shell helper Stefano Brivio
2022-09-24  2:59     ` David Gibson
2022-09-23  7:20 ` [PATCH 02/12] test: Remove unnecessary sleeps from layout functions David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-24  3:02     ` David Gibson
2022-09-23  7:20 ` [PATCH 03/12] test: Remove unnecessary sleeps from shutdown tests David Gibson
2022-09-23  7:20 ` [PATCH 04/12] test: More robust wait for pasta/passt to be ready David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-24  3:03     ` David Gibson
2022-09-23  7:20 ` [PATCH 05/12] test: Use --config-net for namespace setup David Gibson
2022-09-23  7:20 ` [PATCH 06/12] test: Simplify data handling for transfer tests David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-23  7:20 ` [PATCH 07/12] test: Remove unneccessary pane naming from layout_two_guests David Gibson
2022-09-23  7:20 ` [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-24  3:06     ` David Gibson
2022-09-23  7:20 ` [PATCH 09/12] cppcheck: Avoid excessive scanning due to system headers David Gibson
2022-09-23  7:20 ` [PATCH 10/12] cppcheck: Run quietly David Gibson
2022-09-23  7:20 ` [PATCH 11/12] Makefile: Simplify getting target triple for compiler David Gibson
2022-09-23  7:20 ` [PATCH 12/12] cppcheck: Add target specific headers David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923072038.1667106-2-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).