public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH 02/12] test: Remove unnecessary sleeps from layout functions
Date: Fri, 23 Sep 2022 17:20:28 +1000	[thread overview]
Message-ID: <20220923072038.1667106-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20220923072038.1667106-1-david@gibson.dropbear.id.au>

[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]

These make sense for displaying in the demo, but not for automated
testing.

Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
 test/lib/layout | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/test/lib/layout b/test/lib/layout
index cf319bf..9b16c4d 100644
--- a/test/lib/layout
+++ b/test/lib/layout
@@ -15,8 +15,6 @@
 
 # layout_host() - Simple host commands layout with info and host panes
 layout_host() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -39,14 +37,10 @@ layout_host() {
 	fi
 
 	info_layout "host commands only"
-
-	sleep 1
 }
 
 # layout_pasta() - Panes for host, pasta, and separate one for namespace
 layout_pasta() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -70,14 +64,10 @@ layout_pasta() {
 	pane_watch_contexts ${PANE_NS} "namespace" unshare ns
 
 	info_layout "single pasta instance with namespace"
-
-	sleep 1
 }
 
 # layout_passt() - Panes for host, passt, and guest
 layout_passt() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -101,14 +91,10 @@ layout_passt() {
 	pane_watch_contexts ${PANE_GUEST} guest qemu guest
 
 	info_layout "single passt instance with guest"
-
-	sleep 1
 }
 
 # layout_passt_in_pasta() - Host, passt within pasta, namespace and guest
 layout_passt_in_pasta() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -137,14 +123,10 @@ layout_passt_in_pasta() {
 	pane_watch_contexts ${PANE_PASST} "passt in pasta (namespace)" pasta passt
 
 	info_layout "passt and guest in namespace, connected by pasta"
-
-	sleep 1
 }
 
 # layout_two_guests() - Two guest panes, two passt panes, plus host and log
 layout_two_guests() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -180,8 +162,6 @@ layout_two_guests() {
 	pane_watch_contexts ${PANE_PASST_2} "passt #2 in namespace #2" pasta_2 passt_2
 
 	info_layout "two guests, two passt instances, in namespaces"
-
-	sleep 1
 }
 
 # layout_demo_pasta() - Four panes for pasta demo
-- 
@@ -15,8 +15,6 @@
 
 # layout_host() - Simple host commands layout with info and host panes
 layout_host() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -39,14 +37,10 @@ layout_host() {
 	fi
 
 	info_layout "host commands only"
-
-	sleep 1
 }
 
 # layout_pasta() - Panes for host, pasta, and separate one for namespace
 layout_pasta() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -70,14 +64,10 @@ layout_pasta() {
 	pane_watch_contexts ${PANE_NS} "namespace" unshare ns
 
 	info_layout "single pasta instance with namespace"
-
-	sleep 1
 }
 
 # layout_passt() - Panes for host, passt, and guest
 layout_passt() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -101,14 +91,10 @@ layout_passt() {
 	pane_watch_contexts ${PANE_GUEST} guest qemu guest
 
 	info_layout "single passt instance with guest"
-
-	sleep 1
 }
 
 # layout_passt_in_pasta() - Host, passt within pasta, namespace and guest
 layout_passt_in_pasta() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -137,14 +123,10 @@ layout_passt_in_pasta() {
 	pane_watch_contexts ${PANE_PASST} "passt in pasta (namespace)" pasta passt
 
 	info_layout "passt and guest in namespace, connected by pasta"
-
-	sleep 1
 }
 
 # layout_two_guests() - Two guest panes, two passt panes, plus host and log
 layout_two_guests() {
-	sleep 3
-
 	tmux kill-pane -a -t 0
 	cmd_write 0 clear
 
@@ -180,8 +162,6 @@ layout_two_guests() {
 	pane_watch_contexts ${PANE_PASST_2} "passt #2 in namespace #2" pasta_2 passt_2
 
 	info_layout "two guests, two passt instances, in namespaces"
-
-	sleep 1
 }
 
 # layout_demo_pasta() - Four panes for pasta demo
-- 
2.37.3


  parent reply	other threads:[~2022-09-23  7:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  7:20 [PATCH 00/12] Assorted test fixes, batch 7 David Gibson
2022-09-23  7:20 ` [PATCH 01/12] test: Add wait_for() shell helper David Gibson
2022-09-23 23:07   ` Stefano Brivio
2022-09-24  2:59     ` David Gibson
2022-09-23  7:20 ` David Gibson [this message]
2022-09-23 23:08   ` [PATCH 02/12] test: Remove unnecessary sleeps from layout functions Stefano Brivio
2022-09-24  3:02     ` David Gibson
2022-09-23  7:20 ` [PATCH 03/12] test: Remove unnecessary sleeps from shutdown tests David Gibson
2022-09-23  7:20 ` [PATCH 04/12] test: More robust wait for pasta/passt to be ready David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-24  3:03     ` David Gibson
2022-09-23  7:20 ` [PATCH 05/12] test: Use --config-net for namespace setup David Gibson
2022-09-23  7:20 ` [PATCH 06/12] test: Simplify data handling for transfer tests David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-23  7:20 ` [PATCH 07/12] test: Remove unneccessary pane naming from layout_two_guests David Gibson
2022-09-23  7:20 ` [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' David Gibson
2022-09-23 23:08   ` Stefano Brivio
2022-09-24  3:06     ` David Gibson
2022-09-23  7:20 ` [PATCH 09/12] cppcheck: Avoid excessive scanning due to system headers David Gibson
2022-09-23  7:20 ` [PATCH 10/12] cppcheck: Run quietly David Gibson
2022-09-23  7:20 ` [PATCH 11/12] Makefile: Simplify getting target triple for compiler David Gibson
2022-09-23  7:20 ` [PATCH 12/12] cppcheck: Add target specific headers David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923072038.1667106-3-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).