From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 06/12] test: Simplify data handling for transfer tests Date: Sat, 24 Sep 2022 01:08:50 +0200 Message-ID: <20220924010850.06ba1e51@elisabeth> In-Reply-To: <20220923072038.1667106-7-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3172349059294110834==" --===============3172349059294110834== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Fri, 23 Sep 2022 17:20:32 +1000 David Gibson wrote: > Many of our tests are based around performing transfers of sample data > across passt/pasta created links. The data flow here can be a bit > hard to follow since, e.g. we create a file transfer it to the guest, > then transfer it back to the host across several different tests. > This also means that the test cases aren't independent of each other. > > Because we don't have the original file available at both ends in some > cases, we compare them by generating md5sums at each end and comparing > them, which is a bit complicated. > > Make a number of changes to simplify this: > 1. Pre-generate the sample data files as a test asset, rather than > building them on the fly during the tests proper > 2. Include the sample data files in the mbuto guest image > 3. Because we have good copies of the original data available in all > contexts, we can now simply use 'cmp' to check if the transfer > has worked, avoiding md5sum complications. > 4. Similarly we can always use the original copy of the sample data > on the send side of each transfer, meaning that the tests become > more independent of each other. > > Signed-off-by: David Gibson > --- > test/.gitignore | 1 + > test/Makefile | 15 +++- > test/passt.mbuto | 6 +- > test/passt/tcp | 53 +++++------- > test/passt/udp | 29 +++---- > test/passt_in_ns/tcp | 187 +++++++++++++++++------------------------- > test/passt_in_ns/udp | 93 +++++++++------------ > test/pasta/tcp | 79 +++++++----------- > test/pasta/udp | 43 ++++------ > test/two_guests/basic | 2 +- > 10 files changed, 214 insertions(+), 294 deletions(-) Uh, yes, this does clean up a lot of mess. -- Stefano --===============3172349059294110834==--