From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' Date: Sat, 24 Sep 2022 01:08:55 +0200 Message-ID: <20220924010855.45e930d6@elisabeth> In-Reply-To: <20220923072038.1667106-9-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1850976991749146124==" --===============1850976991749146124== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Fri, 23 Sep 2022 17:20:34 +1000 David Gibson wrote: > This check complains about any identifier of less than 3 characters. For > locals and parameters this is often pointlessly verbose. Disable it. > > Signed-off-by: David Gibson > --- > Makefile | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 432ee7a..0598865 100644 > --- a/Makefile > +++ b/Makefile > @@ -237,6 +237,10 @@ docs: README.md > # > # - concurrency-mt-unsafe > # TODO: check again if multithreading is implemented > +# > +# - readability-identifier-length > +# Complains about any identifier <3 characters, reasonable for > +# globals, pointlessly verbose for locals and parameters. > > clang-tidy: $(SRCS) $(HEADERS) > clang-tidy -checks=*,-modernize-*,\ > @@ -260,7 +264,7 @@ clang-tidy: $(SRCS) $(HEADERS) > -bugprone-easily-swappable-parameters,\ > -readability-function-cognitive-complexity,\ > -altera-struct-pack-align,\ > - -concurrency-mt-unsafe \ > + -concurrency-mt-unsafe,-readability-identifier-length \ I would rather keep those (unrelated) switches on different lines, I find it's a bit easier to follow through the comments like that. I can change this on merge if you agree, unless you respin. I reviewed the rest of the series, it looks great to me, I have no further observations -- but I haven't tested it yet. -- Stefano --===============1850976991749146124==--