Re: [PATCH] Fix the name of the qemu-system-* executable

[Stefano Brivio <sbrivio@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

On Fri, 23 Sep 2022 11:56:23 +0200
Dario Faggioli <dfaggioli(a)suse.com> wrote:

> Hello everyone!
> 
> So, while playing with out passt package for openSUSE, my colleague
> Vasiliy found out an issue in how passt assumes the qemu binary to be
> called.
> 
> In fact, in openSUSE, while we have a package that allows people to
> launch qemu by invoking `qemu-kvm`, we don't install it by default, and
> we therefore only have the standard upstream names in the filesystem,
> which have the ARCH part in lowercase.

Ah, right. I never noticed because 'kvm' or 'qemu-kvm' were always
there in the environments I use, and the openSUSE test script in the CI:

  https://passt.top/passt/tree/test/distro/opensuse

explicitly passes the path to the qemu binary to qrap.

By the way, for context, as the name might suggest: I'm quite eager to
get rid of qrap, and it looks like we're close. Once native AF_UNIX
support lands in qemu with (further revisions of) Laurent's patchset:

  https://patchwork.kernel.org/project/qemu-devel/list/?series=676445

we can simply tell qemu to connect to passt, without starting it with a
wrapper.

> This patch, which we're currently carrying as a downstream one in our
> package, should fix the problem.
> 
> Thanks and Regards,
> Dario
> ---
> Vasiliy Ulyanov (1):
>       Fix the name of the qemu-system-* executable

For that patch,

Reviewed-by: Stefano Brivio <sbrivio(a)redhat.com>

And while at it: you might want to subscribe to this list:

  https://lists.passt.top/

if you're interested. Right now I'm approving your postings manually as
you're not subscribed, so they are always a bit delayed.

-- 
Stefano