From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 25/28] cppcheck: Remove unused objectIndex suppressions
Date: Wed, 28 Sep 2022 22:58:29 +0200
Message-ID: <20220928225829.03aed371@elisabeth>
In-Reply-To: <20220928043339.613538-26-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9030537555345667334=="

--===============9030537555345667334==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed, 28 Sep 2022 14:33:36 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> I can't get these warnings to trigger on the cppcheck versions I have, so
> remove them.  If we find in future we need to replace these, they should be
> replaced with inline suppressions so its clear what's the section of code
> at issue.

At least for TCP:

-	/* First buffer is to discard data, last one may be partially filled. */
-	iov[-1].iov_len = already_sent;

gone with commit 38fbfdbcb916 ("tcp: Get rid of iov with cached MSS, drop
sendmmsg(), add deferred flush").

-- 
Stefano


--===============9030537555345667334==--