From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH v2 20/28] cppcheck: Suppress same-value-in-ternary branches warning Date: Thu, 29 Sep 2022 13:38:24 +1000 Message-ID: <20220929033832.923149-21-david@gibson.dropbear.id.au> In-Reply-To: <20220929033832.923149-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4546111832470422826==" --===============4546111832470422826== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit TIMER_INTERVAL is the minimum of two separately defined intervals which happen to have the same value at present. This results in an expression which has the same value in both branches of a ternary operator, which cppcheck warngs about. This is logically sound in this case, so suppress the error (we appear to already have a similar suppression for clang-tidy). Also add an unmatchedSuppression suppression, since only some cppcheck versions complain about this instance. Signed-off-by: David Gibson --- passt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/passt.c b/passt.c index 4796c89..2c4a986 100644 --- a/passt.c +++ b/passt.c @@ -305,6 +305,7 @@ int main(int argc, char **argv) loop: /* NOLINTNEXTLINE(bugprone-branch-clone): intervals can be the same */ + /* cppcheck-suppress [duplicateValueTernary, unmatchedSuppression] */ nfds = epoll_wait(c.epollfd, events, EPOLL_EVENTS, TIMER_INTERVAL); if (nfds == -1 && errno != EINTR) { perror("epoll_wait"); -- 2.37.3 --===============4546111832470422826==--