From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 00/28] Fixes for static checkers
Date: Fri, 30 Sep 2022 01:31:22 +0200 [thread overview]
Message-ID: <20220930013122.1f14da46@elisabeth> (raw)
In-Reply-To: <20220929033832.923149-1-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On Thu, 29 Sep 2022 13:38:04 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> The passt tests include two static checking tools: clang-tidy and
> cppcheck. However, newer versions of those tools have introduced
> extra checks, and may cause these tests to fail.
>
> This series fixes all the clang-tidy and cppcheck warnings, either by
> altering our code, or by suppressing them with relevant options to the
> checkers. With this series, the checks are now clean on both my
> Fedora 36 machine (clang-tools-extra-14.0.5-1.fc36.x86_64 and
> cppcheck-2.7.4-2.fc36.x86_64) and my Debian machine (bookworm with
> some pieces from sid: clang-tidy 1:14.0-55.1 and cppcheck 2.9-1).
>
> Changes since v1:
> * Fixed a whitespace error
> * Added extra background information and details to comments and
> commit messages when removing old suppressions
> * Improved conf_runas() rework to give better error messages
Applied, together with your previous batch (#7, v2) of test fixes.
--
Stefano
prev parent reply other threads:[~2022-09-29 23:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 3:38 [PATCH v2 00/28] Fixes for static checkers David Gibson
2022-09-29 3:38 ` [PATCH v2 01/28] Clean up parsing of port ranges David Gibson
2022-09-29 3:38 ` [PATCH v2 02/28] clang-tidy: Suppress warning about unchecked error in logfn macro David Gibson
2022-09-29 3:38 ` [PATCH v2 03/28] clang-tidy: Fix spurious null pointer warning in pasta_start_ns() David Gibson
2022-09-29 3:38 ` [PATCH v2 04/28] clang-tidy: Remove duplicate #include from icmp.c David Gibson
2022-09-29 3:38 ` [PATCH v2 05/28] Catch failures when installing signal handlers David Gibson
2022-09-29 3:38 ` [PATCH v2 06/28] Pack DHCPv6 "on wire" structures David Gibson
2022-09-29 3:38 ` [PATCH v2 07/28] Clean up parsing in conf_runas() David Gibson
2022-09-29 3:38 ` [PATCH v2 08/28] cppcheck: Reduce scope of some variables David Gibson
2022-09-29 3:38 ` [PATCH v2 09/28] Don't shadow 'i' in conf_ports() David Gibson
2022-09-29 3:38 ` [PATCH v2 10/28] Don't shadow global function names David Gibson
2022-09-29 3:38 ` [PATCH v2 11/28] Stricter checking for nsholder.c David Gibson
2022-09-29 3:38 ` [PATCH v2 12/28] cppcheck: Work around false positive NULL pointer dereference error David Gibson
2022-09-29 3:38 ` [PATCH v2 13/28] cppcheck: Use inline suppression for ffsl() David Gibson
2022-09-29 3:38 ` [PATCH v2 14/28] cppcheck: Use inline suppressions for qrap.c David Gibson
2022-09-29 3:38 ` [PATCH v2 15/28] cppcheck: Use inline suppression for strtok() in conf.c David Gibson
2022-09-29 3:38 ` [PATCH v2 16/28] Avoid ugly 'end' members in netlink structures David Gibson
2022-09-29 3:38 ` [PATCH v2 17/28] cppcheck: Broaden suppression for unused struct members David Gibson
2022-09-29 3:38 ` [PATCH v2 18/28] cppcheck: Remove localtime suppression for pcap.c David Gibson
2022-09-29 3:38 ` [PATCH v2 19/28] qrap: Handle case of PATH environment variable being unset David Gibson
2022-09-29 3:38 ` [PATCH v2 20/28] cppcheck: Suppress same-value-in-ternary branches warning David Gibson
2022-09-29 3:38 ` [PATCH v2 21/28] cppcheck: Suppress NULL pointer warning in tcp_sock_consume() David Gibson
2022-09-29 3:38 ` [PATCH v2 22/28] Regenerate seccomp.h if seccomp.sh changes David Gibson
2022-09-29 3:38 ` [PATCH v2 23/28] cppcheck: Avoid errors due to zeroes in bitwise ORs David Gibson
2022-09-29 3:38 ` [PATCH v2 24/28] cppcheck: Remove unused knownConditionTrueFalse suppression David Gibson
2022-09-29 3:38 ` [PATCH v2 25/28] cppcheck: Remove unused objectIndex suppressions David Gibson
2022-09-29 3:38 ` [PATCH v2 26/28] cppcheck: Remove unused va_list_usedBeforeStarted suppression David Gibson
2022-09-29 3:38 ` [PATCH v2 27/28] Mark unused functions for cppcheck David Gibson
2022-09-29 3:38 ` [PATCH v2 28/28] cppcheck: Remove unused unmatchedSuppression suppressions David Gibson
2022-09-29 23:31 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930013122.1f14da46@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).