From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH v2 00/28] Fixes for static checkers Date: Fri, 30 Sep 2022 01:31:22 +0200 Message-ID: <20220930013122.1f14da46@elisabeth> In-Reply-To: <20220929033832.923149-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2665262362735567267==" --===============2665262362735567267== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Thu, 29 Sep 2022 13:38:04 +1000 David Gibson wrote: > The passt tests include two static checking tools: clang-tidy and > cppcheck. However, newer versions of those tools have introduced > extra checks, and may cause these tests to fail. > > This series fixes all the clang-tidy and cppcheck warnings, either by > altering our code, or by suppressing them with relevant options to the > checkers. With this series, the checks are now clean on both my > Fedora 36 machine (clang-tools-extra-14.0.5-1.fc36.x86_64 and > cppcheck-2.7.4-2.fc36.x86_64) and my Debian machine (bookworm with > some pieces from sid: clang-tidy 1:14.0-55.1 and cppcheck 2.9-1). > > Changes since v1: > * Fixed a whitespace error > * Added extra background information and details to comments and > commit messages when removing old suppressions > * Improved conf_runas() rework to give better error messages Applied, together with your previous batch (#7, v2) of test fixes. -- Stefano --===============2665262362735567267==--