public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH] test: Add rudimentary support to run selected tests only
Date: Fri, 07 Oct 2022 09:37:29 +0200	[thread overview]
Message-ID: <20221007093729.5e20b10a@elisabeth> (raw)
In-Reply-To: <Yz/DLKxyuIrWwWSn@yekko>

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

On Fri, 7 Oct 2022 17:11:56 +1100
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Fri, Oct 07, 2022 at 02:47:32AM +0200, Stefano Brivio wrote:
> > To keep this simple, only support tests that have corresponding setup
> > and teardown functions implied by their path. For example:
> > 
> >   ./run passt/ndp
> > 
> > will trigger the 'passt' setup and teardown functions.
> > 
> > This is not really elegant, but it looks robust, and while David is
> > considering proper alternatives, it should be quite useful.
> > 
> > Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>  
> 
> I'm not sure I'd go so far as to call it "robust".  AFAICT it will
> break for cases where the setup function isn't named after the test
> dir (e.g. for perf/* which need the passt_in_ns setup).  And, of
> course, it's still the user's responsibility to handle inter-test
> dependencies (dhcp needs ndp to run first , tcp & udp need dhcp to run
> first , etc.)

Right, well, but I mentioned both facts in the README... ;)

-- 
Stefano


      reply	other threads:[~2022-10-07  7:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07  0:47 [PATCH] test: Add rudimentary support to run selected tests only Stefano Brivio
2022-10-07  6:11 ` David Gibson
2022-10-07  7:37   ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007093729.5e20b10a@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).