From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH v2 0/7] Add support for log file and version display Date: Fri, 07 Oct 2022 13:50:59 +0200 Message-ID: <20221007115106.1983846-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7602828607622066437==" --===============7602828607622066437== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Patches 1/7 to 4/7 add support for logging to a file, via -l/--log-file, with mandatory size limit and rotation. Patches 5/7 and 7/7 fix two minor details that came up while implementing the feature itself. Patch 6/7 adds a --version option with a version string generated by the Makefile using git, if available, and includes the version string in the log header. v2: - Drop patch adding new test from the series (8/8), subject to further discussion - Changes for 4/7 and 6/7 reported in change messages Stefano Brivio (7): Move logging functions to a new file, log.c conf: Drop duplicate, diverging optstring assignments passt.h: Include netinet/if_ether.h before struct ctx declaration log, conf: Add support for logging to file log: Add missing function comment for trace_init() conf, log, Makefile: Add versioning information util: Check return value of lseek() while reading bound ports from procfs Makefile | 9 +- README.md | 2 +- conf.c | 74 ++++++++--- dhcp.c | 1 + dhcpv6.c | 1 + icmp.c | 1 + isolation.c | 1 + log.c | 363 +++++++++++++++++++++++++++++++++++++++++++++++++++ log.h | 32 +++++ ndp.c | 1 + netlink.c | 1 + packet.c | 1 + passt.1 | 18 ++- passt.c | 2 + passt.h | 2 + pasta.c | 1 + pcap.c | 1 + tap.c | 1 + tcp.c | 1 + tcp_splice.c | 1 + udp.c | 1 + util.c | 131 ++----------------- util.h | 22 +--- 23 files changed, 509 insertions(+), 159 deletions(-) create mode 100644 log.c create mode 100644 log.h -- 2.35.1 --===============7602828607622066437==--