public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: [PATCH] netlink: Disable duplicate address detection for configured IPv6 address
Date: Tue, 11 Oct 2022 01:33:08 +0200	[thread overview]
Message-ID: <20221010233308.1198341-1-sbrivio@redhat.com> (raw)

With default options, when we pass --config-net, the IPv6 address is
actually going to be recycled from the init namespace, so it is in
fact duplicated, but duplicate address detection has no way to find
out.

With a different configured address, that's not the case, but anyway
duplicate address detection will be unable to see this.

In both cases, we're wasting time for nothing.

Pass the IFA_F_NODAD flag as we configure globally scoped IPv6
addresses via netlink.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 netlink.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/netlink.c b/netlink.c
index 9719e91..6e5a96b 100644
--- a/netlink.c
+++ b/netlink.c
@@ -343,6 +343,9 @@ void nl_addr(int ns, unsigned int ifi, sa_family_t af,
 		if (af == AF_INET6) {
 			size_t rta_len = RTA_LENGTH(sizeof(req.set.a6.l));
 
+			/* By default, strictly speaking, it's duplicated */
+			req.ifa.ifa_flags = IFA_F_NODAD;
+
 			req.nlh.nlmsg_len = offsetof(struct req_t, set.a6)
 				+ sizeof(req.set.a6);
 
-- 
@@ -343,6 +343,9 @@ void nl_addr(int ns, unsigned int ifi, sa_family_t af,
 		if (af == AF_INET6) {
 			size_t rta_len = RTA_LENGTH(sizeof(req.set.a6.l));
 
+			/* By default, strictly speaking, it's duplicated */
+			req.ifa.ifa_flags = IFA_F_NODAD;
+
 			req.nlh.nlmsg_len = offsetof(struct req_t, set.a6)
 				+ sizeof(req.set.a6);
 
-- 
2.35.1


             reply	other threads:[~2022-10-10 23:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 23:33 Stefano Brivio [this message]
2022-10-11  0:51 ` [PATCH] netlink: Disable duplicate address detection for configured IPv6 address David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221010233308.1198341-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).