* [PATCH] util.h: Add missing gcc pragma push before pragma pop
@ 2022-10-12 15:45 Stefano Brivio
2022-10-13 1:14 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2022-10-12 15:45 UTC (permalink / raw)
To: passt-dev
While building with clang:
./util.h:176:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas]
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
util.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/util.h b/util.h
index b1eadfd..4d1b375 100644
--- a/util.h
+++ b/util.h
@@ -165,6 +165,7 @@
struct ctx;
struct ipv6hdr {
+#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
#if __BYTE_ORDER == __BIG_ENDIAN
uint8_t version:4,
--
@@ -165,6 +165,7 @@
struct ctx;
struct ipv6hdr {
+#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
#if __BYTE_ORDER == __BIG_ENDIAN
uint8_t version:4,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] util.h: Add missing gcc pragma push before pragma pop
2022-10-12 15:45 [PATCH] util.h: Add missing gcc pragma push before pragma pop Stefano Brivio
@ 2022-10-13 1:14 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2022-10-13 1:14 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Wed, Oct 12, 2022 at 05:45:40PM +0200, Stefano Brivio wrote:
> While building with clang:
>
> ./util.h:176:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas]
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> util.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util.h b/util.h
> index b1eadfd..4d1b375 100644
> --- a/util.h
> +++ b/util.h
> @@ -165,6 +165,7 @@
> struct ctx;
>
> struct ipv6hdr {
> +#pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wpedantic"
> #if __BYTE_ORDER == __BIG_ENDIAN
> uint8_t version:4,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-13 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 15:45 [PATCH] util.h: Add missing gcc pragma push before pragma pop Stefano Brivio
2022-10-13 1:14 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).