From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B27BE5A0265 for ; Thu, 13 Oct 2022 04:44:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665629079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CtPqLcU0QPA21HPSvr8qGqzaSo9WD0HFDOogx+4Ieog=; b=L+pjMUQwW9YA2RoS3W87YVdlcembJs/AeO+1YP/5P73LMMGtr/aaQd2HUk5eHF9uIln4NV gvyyXOOsKTyiRSDeWqiC6PapDSPB4yJIyrcHfw5TtpzJuUlYcaMhsgAEIdSiAPtZs/hUXe nCYyXkotCIIXMSnyxUKs0iFUE0z6yM4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-385-tzEWjl90NiKXQ0cMjqdsGg-1; Wed, 12 Oct 2022 22:44:36 -0400 X-MC-Unique: tzEWjl90NiKXQ0cMjqdsGg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84E861C05129; Thu, 13 Oct 2022 02:44:36 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-3.brq.redhat.com [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43C8CC47DE7; Thu, 13 Oct 2022 02:44:36 +0000 (UTC) Date: Thu, 13 Oct 2022 04:44:23 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 00/10] Fixes and cleanups for capability handling Message-ID: <20221013044423.2fc0d429@elisabeth> In-Reply-To: <20221011054018.1449506-1-david@gibson.dropbear.id.au> References: <20221011054018.1449506-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NNZT56MHGSCVDQWD5UQJXMV7CUX24SGR X-Message-ID-Hash: NNZT56MHGSCVDQWD5UQJXMV7CUX24SGR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 11 Oct 2022 16:40:08 +1100 David Gibson wrote: > Our current handling of capabilities isn't quite right. In > particular, drop_caps() attempts to remove capabilities from the > bounding set, which usually won't work, and even if it does won't have > the effect we want. > > This series corrects that, as well as making some other fixes and > cleanups in adjacent code. Other than those entirely formal details I reported (...and I tried hard), this looks great to me, and feels like a relief. :) -- Stefano