public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/11] Fixes and cleanups for capability handling
Date: Fri, 14 Oct 2022 15:25:26 +1100	[thread overview]
Message-ID: <20221014042537.2466015-1-david@gibson.dropbear.id.au> (raw)

Our current handling of capabilities isn't quite right.  In
particular, drop_caps() attempts to remove capabilities from the
bounding set, which usually won't work, and even if it does won't have
the effect we want.

This series corrects that, as well as making some other fixes and
cleanups in adjacent code.

Changes since v1:
 * A number of minor style fixes
 * Should now correctly handle the case where we join an existing
   userns/netns, or just an existing netns (--netns-only)

David Gibson (11):
  test: Move slower tests to end of test run
  pasta: More general way of starting spawned shell as a login shell
  pasta_start_ns() always ends in parent context
  Remove unhelpful drop_caps() call in pasta_start_ns()
  isolation: Clarify various self-isolation steps
  Replace FWRITE with a function
  isolation: Refactor isolate_user() to allow for a common exit path
  isolation: Replace drop_caps() with a version that actually does
    something
  isolation: Prevent any child processes gaining capabilities
  isolation: Only configure UID/GID mappings in userns when spawning
    shell
  Rename pasta_setup_ns() to pasta_spawn_cmd()

 conf.c      |   5 +-
 isolation.c | 255 +++++++++++++++++++++++++++++++++++++++++++++-------
 isolation.h |   9 +-
 passt.c     |   8 +-
 pasta.c     |  72 +++++++++------
 pasta.h     |   3 +-
 test/run    |  20 ++---
 util.c      |  33 +++++++
 util.h      |  13 +--
 9 files changed, 324 insertions(+), 94 deletions(-)

-- 
2.37.3


             reply	other threads:[~2022-10-14  4:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  4:25 David Gibson [this message]
2022-10-14  4:25 ` [PATCH v2 01/11] test: Move slower tests to end of test run David Gibson
2022-10-14  4:25 ` [PATCH v2 02/11] pasta: More general way of starting spawned shell as a login shell David Gibson
2022-10-14  4:25 ` [PATCH v2 03/11] pasta_start_ns() always ends in parent context David Gibson
2022-10-14  4:25 ` [PATCH v2 04/11] Remove unhelpful drop_caps() call in pasta_start_ns() David Gibson
2022-10-14  4:25 ` [PATCH v2 05/11] isolation: Clarify various self-isolation steps David Gibson
2022-10-14  4:25 ` [PATCH v2 06/11] Replace FWRITE with a function David Gibson
2022-10-14  4:25 ` [PATCH v2 07/11] isolation: Refactor isolate_user() to allow for a common exit path David Gibson
2022-10-14  4:25 ` [PATCH v2 08/11] isolation: Replace drop_caps() with a version that actually does something David Gibson
2022-10-14  4:25 ` [PATCH v2 09/11] isolation: Prevent any child processes gaining capabilities David Gibson
2022-10-14  4:25 ` [PATCH v2 10/11] isolation: Only configure UID/GID mappings in userns when spawning shell David Gibson
2022-10-14  4:25 ` [PATCH v2 11/11] Rename pasta_setup_ns() to pasta_spawn_cmd() David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014042537.2466015-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).