From: Stefano Brivio <sbrivio@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: passt crashes on CentOS Stream 9
Date: Fri, 21 Oct 2022 21:33:11 +0200 [thread overview]
Message-ID: <20221021213311.16cb0188@elisabeth> (raw)
In-Reply-To: <20221021211508.5194f6b1@elisabeth>
On Fri, 21 Oct 2022 21:15:07 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> On Fri, 21 Oct 2022 20:48:20 +0200
> Stefano Brivio <sbrivio@redhat.com> wrote:
>
> > Could you also quickly try to start it with strace and report a couple
> > of lines before the mischief?
>
> Never mind, just reproduced...
Another workaround:
diff --git a/util.h b/util.h
index 27829b1..64b9a26 100644
--- a/util.h
+++ b/util.h
@@ -72,7 +72,7 @@
#define IPV4_IS_LOOPBACK(addr) \
((addr) >> IN_CLASSA_NSHIFT == IN_LOOPBACKNET)
-#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 4)
+#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 10)
#define NS_CALL(fn, arg) \
do { \
char ns_fn_stack[NS_FN_STACK_SIZE]; \
...we need to harden this "against" -fstack-protector-strong when
inlining gets quite extreme due to LTO, with some build-time
assertions, or a more reasonable (and involved) calculation of what
ns_fn_stack really needs.
I'll try to send a patch soon (again, if nobody beats me at it).
--
@@ -72,7 +72,7 @@
#define IPV4_IS_LOOPBACK(addr) \
((addr) >> IN_CLASSA_NSHIFT == IN_LOOPBACKNET)
-#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 4)
+#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 10)
#define NS_CALL(fn, arg) \
do { \
char ns_fn_stack[NS_FN_STACK_SIZE]; \
...we need to harden this "against" -fstack-protector-strong when
inlining gets quite extreme due to LTO, with some build-time
assertions, or a more reasonable (and involved) calculation of what
ns_fn_stack really needs.
I'll try to send a patch soon (again, if nobody beats me at it).
--
Stefano
next prev parent reply other threads:[~2022-10-21 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 17:05 passt crashes on CentOS Stream 9 Andrea Bolognani
2022-10-21 18:48 ` Stefano Brivio
2022-10-21 19:15 ` Stefano Brivio
2022-10-21 19:33 ` Stefano Brivio [this message]
2022-10-22 8:57 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021213311.16cb0188@elisabeth \
--to=sbrivio@redhat.com \
--cc=abologna@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).