From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id C02525A0082 for ; Fri, 21 Oct 2022 21:33:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666380812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BG52Zc0XtjB+reXY2+sAgKW8xGRYBdBoxCegC0TJWh4=; b=HlYx6Q5LXc83y95K9QFhgKNFg3Xg/+EYZ6z7lF0Uqg6GBEH87C36ykhIDF5bFdpX9ANDxt P/ITTYFCLFeLlAJb7NgUXvbQlzm4PGNdoMZ7sSq4EoMZwsq+cGoZT6DYcJCKR+AnzDuQKx b/uTCMTyICIj8S2m6EsBk0tI+kF9YT4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-148-NLD5nTuuPzmdoZuczNY_PQ-1; Fri, 21 Oct 2022 15:33:31 -0400 X-MC-Unique: NLD5nTuuPzmdoZuczNY_PQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37B20101A588 for ; Fri, 21 Oct 2022 19:33:21 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1A7A140EBF3; Fri, 21 Oct 2022 19:33:15 +0000 (UTC) Date: Fri, 21 Oct 2022 21:33:11 +0200 From: Stefano Brivio To: Andrea Bolognani Subject: Re: passt crashes on CentOS Stream 9 Message-ID: <20221021213311.16cb0188@elisabeth> In-Reply-To: <20221021211508.5194f6b1@elisabeth> References: <20221021204820.58e2b338@elisabeth> <20221021211508.5194f6b1@elisabeth> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: R5XIPNKSZV5NSO7DEXSYLN6SKOBNB6QL X-Message-ID-Hash: R5XIPNKSZV5NSO7DEXSYLN6SKOBNB6QL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Oct 2022 21:15:07 +0200 Stefano Brivio wrote: > On Fri, 21 Oct 2022 20:48:20 +0200 > Stefano Brivio wrote: > > > Could you also quickly try to start it with strace and report a couple > > of lines before the mischief? > > Never mind, just reproduced... Another workaround: diff --git a/util.h b/util.h index 27829b1..64b9a26 100644 --- a/util.h +++ b/util.h @@ -72,7 +72,7 @@ #define IPV4_IS_LOOPBACK(addr) \ ((addr) >> IN_CLASSA_NSHIFT == IN_LOOPBACKNET) -#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 4) +#define NS_FN_STACK_SIZE (RLIMIT_STACK_VAL * 1024 / 10) #define NS_CALL(fn, arg) \ do { \ char ns_fn_stack[NS_FN_STACK_SIZE]; \ ...we need to harden this "against" -fstack-protector-strong when inlining gets quite extreme due to LTO, with some build-time assertions, or a more reasonable (and involved) calculation of what ns_fn_stack really needs. I'll try to send a patch soon (again, if nobody beats me at it). -- Stefano