From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 931F25A0265 for ; Mon, 24 Oct 2022 23:00:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666645245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLR4BHItR0DyowALiOJj9fGTdq8HvQrlM5MOi+fCH3o=; b=QBtdufahdncQf1CVhWDPmism8iSj6OYhS50nIRriYuPquVMZHjYwJkS3Q+NOVv0XlNokDw WXqIy96v4FTbMkuIgQmEa6wnh0DrNCYXxsv35Q37uYekySrtF/1rWmFq8DNjocY7W2339K driE6UqJxkE+XXsUW5LgYMiFxgtpNXI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-vkZ_TkB_ODWTZStBe5-S9A-1; Mon, 24 Oct 2022 17:00:41 -0400 X-MC-Unique: vkZ_TkB_ODWTZStBe5-S9A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89B153C11040; Mon, 24 Oct 2022 21:00:41 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C263492CA2; Mon, 24 Oct 2022 21:00:40 +0000 (UTC) Date: Mon, 24 Oct 2022 23:00:31 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 8/8] test: Add log file tests for pasta plus corresponding layout and setup Message-ID: <20221024230031.0f8a5856@elisabeth> In-Reply-To: <20221007114700.181b9514@elisabeth> References: <20221007004742.1188933-1-sbrivio@redhat.com> <20221007004742.1188933-9-sbrivio@redhat.com> <20221007114700.181b9514@elisabeth> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UPV5BWC6MTZQLRSP3HC5Z5JZ7A7OSNOD X-Message-ID-Hash: UPV5BWC6MTZQLRSP3HC5Z5JZ7A7OSNOD X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello, On Fri, 7 Oct 2022 11:47:00 +0200 Stefano Brivio wrote: > But if we can, I'd leave this as a temporary hack, because it's more > usable than the alternative -- for example, I don't have to select two > separate tests for this. As predictable, neither of us had the time to figure out a comprehensive solution for this so far, and I just sent a patch that would need one more instance of this type of test. So... how bad is it, really, if I just go ahead and merge this, and then add another test using the same setup function? It looks quite clean to revert, too, the day we find a way to have a context-style setup function that can start a usable interactive shell. -- Stefano