From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 317A75A0265 for ; Wed, 26 Oct 2022 09:27:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666769221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b/BiLOuABfKXfN+xlK/dInKIlLKoU4E2PLBSjny/JGo=; b=QGo7rjbSezR6Ra29K3gOfy04/tceAnsPmUp2m8JB9+xZ7kFXU0BFgQr3TVGg0cdN3VivfW K8ZmxxZ+avLak2miH4PpTWCiCcKGYNttwnka/hJ6ogyjkV/6y123+PO/iPmY0VIIgOey7T t67ICMh0Cxr5M1DsXAgMZg2U5V1j3t0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-ScjRsTHdPwOHU6g6k0ayRA-1; Wed, 26 Oct 2022 03:26:17 -0400 X-MC-Unique: ScjRsTHdPwOHU6g6k0ayRA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95BD1811E87; Wed, 26 Oct 2022 07:26:16 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39121C15BAB; Wed, 26 Oct 2022 07:26:16 +0000 (UTC) Date: Wed, 26 Oct 2022 09:26:09 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 8/8] test: Add log file tests for pasta plus corresponding layout and setup Message-ID: <20221026092609.2c109b4d@elisabeth> In-Reply-To: <20221024230031.0f8a5856@elisabeth> References: <20221007004742.1188933-1-sbrivio@redhat.com> <20221007004742.1188933-9-sbrivio@redhat.com> <20221007114700.181b9514@elisabeth> <20221024230031.0f8a5856@elisabeth> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GH6H6ISBMJLLQRPVQGRAE57JZN6AA5ZB X-Message-ID-Hash: GH6H6ISBMJLLQRPVQGRAE57JZN6AA5ZB X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 24 Oct 2022 23:00:31 +0200 Stefano Brivio wrote: > Hello, > > On Fri, 7 Oct 2022 11:47:00 +0200 > Stefano Brivio wrote: > > > But if we can, I'd leave this as a temporary hack, because it's more > > usable than the alternative -- for example, I don't have to select two > > separate tests for this. > > As predictable, neither of us had the time to figure out a > comprehensive solution for this so far, and I just sent a patch that > would need one more instance of this type of test. > > So... how bad is it, really, if I just go ahead and merge this, and > then add another test using the same setup function? It looks quite > clean to revert, too, the day we find a way to have a context-style > setup function that can start a usable interactive shell. I just merged it. As I'm going through the bug tracker and filing a number of items, I'll track this there as well. -- Stefano