From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/4] Improve IPv4 address endian handling and related bug fixes
Date: Thu, 3 Nov 2022 14:09:21 +1100 [thread overview]
Message-ID: <20221103030925.2561571-1-david@gibson.dropbear.id.au> (raw)
While working on allowing us to use IPv4/IPv6 combined listening
sockets, I made several endian mistakes. So, I took a diversion to
make it harder to make such mistakes.
Along the way I found some small existing endian and other bugs in
IPv4 address handling.
David Gibson (4):
Correct some missing endian conversions of IPv4 addresses
Minor improvements to IPv4 netmask handling
Use IPV4_IS_LOOPBACK more widely
Use typing to reduce chances of IPv4 endianness errors
checksum.c | 7 ++--
checksum.h | 3 +-
conf.c | 118 ++++++++++++++++++++++++++++++-----------------------
dhcp.c | 15 ++++---
icmp.c | 5 +--
passt.c | 2 +-
passt.h | 16 ++++----
pasta.c | 7 +---
tap.c | 18 ++++----
tap.h | 8 ++--
tcp.c | 48 +++++++++++-----------
tcp.h | 2 +-
udp.c | 30 +++++++-------
udp.h | 2 +-
util.h | 12 +++++-
15 files changed, 160 insertions(+), 133 deletions(-)
--
2.38.1
next reply other threads:[~2022-11-03 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 3:09 David Gibson [this message]
2022-11-03 3:09 ` [PATCH 1/4] Correct some missing endian conversions of IPv4 addresses David Gibson
2022-11-03 3:09 ` [PATCH 2/4] Minor improvements to IPv4 netmask handling David Gibson
2022-11-03 3:09 ` [PATCH 3/4] Use IPV4_IS_LOOPBACK more widely David Gibson
2022-11-03 3:09 ` [PATCH 4/4] Use typing to reduce chances of IPv4 endianness errors David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103030925.2561571-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).