public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v3 5/5] test: Add memory/passt test cases
Date: Thu, 3 Nov 2022 07:35:58 +0100	[thread overview]
Message-ID: <20221103073558.603c7d20@elisabeth> (raw)
In-Reply-To: <Y2M6pHpr2gCn4siq@yekko>

On Thu, 3 Nov 2022 14:51:00 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Thu, Nov 03, 2022 at 12:13:07AM +0100, Stefano Brivio wrote:
>
> [...]
>
> > diff --git a/test/lib/layout_ugly b/test/lib/layout_ugly
> > index 9397b7d..e8daaa4 100644
> > --- a/test/lib/layout_ugly
> > +++ b/test/lib/layout_ugly
> > @@ -81,3 +81,37 @@ layout_pasta_simple() {
> >  
> >  	sleep 1
> >  }
> > +
> > +# layout_memory() - Screen-scraped panes for memory usage tests, big guest pane
> > +layout_memory() {
> > +	sleep 3
> > +
> > +	tmux kill-pane -a -t 0
> > +	cmd_write 0 clear
> > +
> > +	tmux split-window -h -l '35%' -t passt_test
> > +	tmux split-window -v -l '15%' -t passt_test  
> 
> I see you still have the unnecessary host side passt.  If you don't
> want to fold my patch to remove that, it would at least make sense to
> put it in the same series, no?

I left that in so that I could still reasonably apply your series, but
sure, if you actually wanted me to fold that... done in v4.

-- 
Stefano


      reply	other threads:[~2022-11-03  6:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 23:13 [PATCH v3 0/5] Test cases to display memory usage in kernel and userspace Stefano Brivio
2022-11-02 23:13 ` [PATCH v3 1/5] test/lib: Move screen-scraping setup and layout functions to _ugly files Stefano Brivio
2022-11-02 23:13 ` [PATCH v3 2/5] tap: Support for detection of existing sockets on ramfs Stefano Brivio
2022-11-02 23:13 ` [PATCH v3 3/5] test/lib/perf_report: Use own flag to track initialisation Stefano Brivio
2022-11-02 23:13 ` [PATCH v3 4/5] test/lib: Add "td" directive, handled by table_value() Stefano Brivio
2022-11-02 23:13 ` [PATCH v3 5/5] test: Add memory/passt test cases Stefano Brivio
2022-11-03  3:51   ` David Gibson
2022-11-03  6:35     ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103073558.603c7d20@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).