public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Cc: Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH v2 2/3] conf: Split the notions of read DNS addresses and offered ones
Date: Thu, 3 Nov 2022 08:10:00 +0100	[thread overview]
Message-ID: <20221103081000.0bab23a9@elisabeth> (raw)
In-Reply-To: <20221103063341.401251-3-sbrivio@redhat.com>

On Thu,  3 Nov 2022 07:33:40 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> With --dns-forward, if the host has a loopback address configured as
> DNS server, we should actually use it to forward queries, but, if
> --no-map-gw is passed, we shouldn't offer the same address via DHCP,
> NDP and DHCPv6, because it's not going to be reachable.
> 
> Problematic configuration:
> 
> * systemd-resolved configuring the usual 127.0.0.53 on the host: we
>   read that from /etc/resolv.conf
> 
> * --dns-forward specified with an unrelated address, for example
>   198.51.100.1
> 
> We still want to forward queries to 127.0.0.53, if we receive one
> directed to 198.51.100.1, so we can't drop 127.0.0.53 from our list:
> we want to use it for forwarding. At the same time, we shouldn't
> offer 127.0.0.53 to the guest or container either.
> 
> With this change, I'm only covering the case of automatically
> configured DNS servers from /etc/resolv.conf. We could extend this to
> addresses configured with command-line options, but I don't really
> see a likely use case at this point.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Oops, disregard this, I botched the rebase in conf.c.

-- 
Stefano


  reply	other threads:[~2022-11-03  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03  6:33 [PATCH v2 0/3] Fixes and workarounds for pasta with Podman in Google Cloud Stefano Brivio
2022-11-03  6:33 ` [PATCH v2 1/3] conf: Consistency check between configured IPv4 netmask and gateway Stefano Brivio
2022-11-03  6:33 ` [PATCH v2 2/3] conf: Split the notions of read DNS addresses and offered ones Stefano Brivio
2022-11-03  7:10   ` Stefano Brivio [this message]
2022-11-03  6:33 ` [PATCH v2 3/3] udp: Check for answers to forwarded DNS queries before handling local redirects Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103081000.0bab23a9@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).