From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 00/14] RFC: tcp: Don't use separate listening sockets for spliced and non-spliced connections
Date: Tue, 15 Nov 2022 02:22:41 +0100 [thread overview]
Message-ID: <20221115022242.21235140@elisabeth> (raw)
In-Reply-To: <20221114061711.1655510-1-david@gibson.dropbear.id.au>
On Mon, 14 Nov 2022 17:16:57 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> We can splice TCP connections in pasta mode if and only if they
> originate from localhost. Currently we separate the two cases by
> having separate listening sockets: one listens on the host address for
> non-spliceable connections, the other listens on the loopback address
> for spliceable connections.
I couldn't finish reviewing the whole series in detail yet, but I had a
look at all the patches and, except for a couple of minor style issues
(those are the ones I still need to finish checking), I couldn't see any
flaw -- all the single patches look fine to me.
--
Stefano
next prev parent reply other threads:[~2022-11-15 1:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 6:16 [PATCH 00/14] RFC: tcp: Don't use separate listening sockets for spliced and non-spliced connections David Gibson
2022-11-14 6:16 ` [PATCH 01/14] style: Minor corrections to function comments David Gibson
2022-11-14 6:16 ` [PATCH 02/14] tcp: Remove unused TCP_MAX_SOCKS constant David Gibson
2022-11-14 6:17 ` [PATCH 03/14] tcp: Better helpers for converting between connection pointer and index David Gibson
2022-11-14 6:17 ` [PATCH 04/14] tcp_splice: Helpers for converting from index to/from tcp_splice_conn David Gibson
2022-11-14 6:17 ` [PATCH 05/14] tcp: Move connection state structures into a shared header David Gibson
2022-11-14 6:17 ` [PATCH 06/14] tcp: Add connection union type David Gibson
2022-11-14 6:17 ` [PATCH 07/14] tcp: Improved helpers to update connections after moving David Gibson
2022-11-14 6:17 ` [PATCH 08/14] tcp: Unify spliced and non-spliced connection tables David Gibson
2022-11-14 6:17 ` [PATCH 09/14] tcp: Unify tcp_defer_handler and tcp_splice_defer_handler() David Gibson
2022-11-14 6:17 ` [PATCH 10/14] tcp: Partially unify tcp_timer() and tcp_splice_timer() David Gibson
2022-11-14 6:17 ` [PATCH 11/14] tcp: Unify the IN_EPOLL flag David Gibson
2022-11-14 6:17 ` [PATCH 12/14] tcp: Separate helpers to create ns listening sockets David Gibson
2022-11-14 6:17 ` [PATCH 13/14] tcp: Unify part of spliced and non-spliced conn_from_sock path David Gibson
2022-11-14 6:17 ` [PATCH 14/14] tcp: Use the same sockets to listen for spliced and non-spliced connections David Gibson
2022-11-15 1:22 ` Stefano Brivio [this message]
2022-11-15 4:57 ` [PATCH 00/14] RFC: tcp: Don't use separate listening sockets " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115022242.21235140@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).