From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B14F05A0082 for ; Tue, 15 Nov 2022 02:22:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668475374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pt1bQlzeRFWkzV1NGtITxKJk+TNmsYVgJ0H+4ZymM04=; b=SveuA3gUyliWDPyx6VWkzWNuYa719X0W+HEyuvt2csAPjii27I/0oDHVmmqaw+XljJkscV Tcoxml3LNkt1eUQxtp0uh55PqPbJ+fvRA2YcxtiO1MXTD3E5LnUWs9h7/ecWLASueDUcYE 4jBNv3vVPa4o0FWbaBOkATLpghZCXcg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-nUwcJMWhP5GLsxX0rjfrQg-1; Mon, 14 Nov 2022 20:22:52 -0500 X-MC-Unique: nUwcJMWhP5GLsxX0rjfrQg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 62113101A52A; Tue, 15 Nov 2022 01:22:52 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-9.brq.redhat.com [10.40.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D95BC40C83EE; Tue, 15 Nov 2022 01:22:51 +0000 (UTC) Date: Tue, 15 Nov 2022 02:22:41 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 00/14] RFC: tcp: Don't use separate listening sockets for spliced and non-spliced connections Message-ID: <20221115022242.21235140@elisabeth> In-Reply-To: <20221114061711.1655510-1-david@gibson.dropbear.id.au> References: <20221114061711.1655510-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 5XFJIO2AWVR5YVS74HJVN6BHBUQD47F6 X-Message-ID-Hash: 5XFJIO2AWVR5YVS74HJVN6BHBUQD47F6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 14 Nov 2022 17:16:57 +1100 David Gibson wrote: > We can splice TCP connections in pasta mode if and only if they > originate from localhost. Currently we separate the two cases by > having separate listening sockets: one listens on the host address for > non-spliceable connections, the other listens on the loopback address > for spliceable connections. I couldn't finish reviewing the whole series in detail yet, but I had a look at all the patches and, except for a couple of minor style issues (those are the ones I still need to finish checking), I couldn't see any flaw -- all the single patches look fine to me. -- Stefano