From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 8306A5A0273 for ; Wed, 16 Nov 2022 05:42:21 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NBr4R0KY8z4xZh; Wed, 16 Nov 2022 15:42:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668573735; bh=M8iDLaa/y4XsGcJd5VI3te2y9NXLJR3VH/05M7seiwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fnDMz1f7JD0WlFkN20ahzKdfdTAqQKB71FVCJt9Xolc2CobwvN3/geuwwpDfRfId2 KdT7/IexUq0jsg9tAUG/4fD49ri2jAYSehpp9vOg7MiVRhB3Vx0Xs2T9nAxdYuA56S X2LdLz4BDZdvNgNyVGBM50U4uAm4GeQ8DRxnUHeQ= From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 01/32] clang-tidy: Suppress warning about assignments in if statements Date: Wed, 16 Nov 2022 15:41:41 +1100 Message-Id: <20221116044212.3876516-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116044212.3876516-1-david@gibson.dropbear.id.au> References: <20221116044212.3876516-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: YHRKHZ6QS4GVUHDNMV2QAHPV5G3M6A5L X-Message-ID-Hash: YHRKHZ6QS4GVUHDNMV2QAHPV5G3M6A5L X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: clang-tools 15.0.0 appears to have added a new warning that will always complain about assignments in if statements, which we use in a number of places in passt/pasta. Encountered on Fedora 37 with clang-tools-extra-15.0.0-3.fc37.x86_64. Suppress the new warning so that we can compile and test. Signed-off-by: David Gibson --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 6b22408..8bcbbc0 100644 --- a/Makefile +++ b/Makefile @@ -262,6 +262,7 @@ clang-tidy: $(SRCS) $(HEADERS) clang-tidy -checks=*,-modernize-*,\ -clang-analyzer-valist.Uninitialized,\ -cppcoreguidelines-init-variables,\ + -bugprone-assignment-in-if-condition,\ -bugprone-macro-parentheses,\ -google-readability-braces-around-statements,\ -hicpp-braces-around-statements,\ -- 2.38.1