From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 5/8] util, pasta: Use __clone2() instead of clone() on ia64
Date: Wed, 16 Nov 2022 09:12:31 +0100 [thread overview]
Message-ID: <20221116091231.3caef387@elisabeth> (raw)
In-Reply-To: <Y3RyWXfjkBRB14cv@yekko>
On Wed, 16 Nov 2022 16:17:13 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Tue, Nov 15, 2022 at 02:23:46AM +0100, Stefano Brivio wrote:
> > On ia64, clone(2) is not available: the glibc wrapper is named
> > __clone2() and it takes, additionally, the size of the stack area
> > passed by the caller.
> >
> > Spotted in Debian's buildd logs.
> >
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
>
> Urgh, I'd really prefer to make our own wrapper to reduce two ifdefs
> to one.
Hmm, right. I'd go with:
__clone(int (*fn)(void *), void *stack_base, size_t stack_size,
int flags, void *arg)
...where stack_base is ns_fn_stack. Better ideas (especially for the
name)?
--
Stefano
next prev parent reply other threads:[~2022-11-16 23:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 1:23 [PATCH 0/8] Fixes for Debian package functionality and build Stefano Brivio
2022-11-15 1:23 ` [PATCH 1/8] Makefile: Honour passed CPPFLAGS, not just CFLAGS Stefano Brivio
2022-11-15 5:00 ` David Gibson
2022-11-15 1:23 ` [PATCH 2/8] Makefile: Don't filter out -O2 from supplied flags for AVX2 builds Stefano Brivio
2022-11-15 5:15 ` David Gibson
2022-11-15 1:23 ` [PATCH 3/8] Makefile: It's AUDIT_ARCH_MIPSEL64, not AUDIT_ARCH_MIPS64EL Stefano Brivio
2022-11-16 5:14 ` David Gibson
2022-11-15 1:23 ` [PATCH 4/8] Makefile: Change HPPA into PARISC while building PASST_AUDIT_ARCH Stefano Brivio
2022-11-16 5:15 ` David Gibson
2022-11-15 1:23 ` [PATCH 5/8] util, pasta: Use __clone2() instead of clone() on ia64 Stefano Brivio
2022-11-16 5:17 ` David Gibson
2022-11-16 8:12 ` Stefano Brivio [this message]
2022-11-15 1:23 ` [PATCH 6/8] README: Add links to Debian package tracker Stefano Brivio
2022-11-16 5:18 ` David Gibson
2022-11-15 1:23 ` [PATCH 7/8] contrib/apparmor: Merge pasta and passt profiles, update rules Stefano Brivio
2022-11-15 1:23 ` [PATCH 8/8] Remove contrib/debian, Debian package development now happens on Salsa Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116091231.3caef387@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).