From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 8C3345A0082 for ; Thu, 17 Nov 2022 00:53:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668642829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hZr4bCWG31sp1C91hM5tD6EdNiLtqaJW04YhUmfnTYE=; b=cKh/f54tqLFGQ2jgq1l6yKqwe0dNAugZrYojfHMpiG9D63ZTSNp0ATt91NmBTJzzdiLUe4 zifQdZUuzFokLHCFCr8/SCDoWmN6vQJeQTdQxJsLUE48WcyxT5U+gI9YP5077YRooPl/Dl 8gjoQ5opTGRHSXd2ttGesnmbTcr2R7M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-283-6uhUnNI3NWyY1deEabIWhQ-1; Wed, 16 Nov 2022 18:53:46 -0500 X-MC-Unique: 6uhUnNI3NWyY1deEabIWhQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD40085CCFF; Wed, 16 Nov 2022 23:53:45 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-8.brq.redhat.com [10.40.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF1A7492B0E; Wed, 16 Nov 2022 23:53:45 +0000 (UTC) Date: Wed, 16 Nov 2022 09:12:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 5/8] util, pasta: Use __clone2() instead of clone() on ia64 Message-ID: <20221116091231.3caef387@elisabeth> In-Reply-To: References: <20221115012349.2240096-1-sbrivio@redhat.com> <20221115012349.2240096-6-sbrivio@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AC4GGTXT2WLIRD7APFDDCXZO3XVKUDJS X-Message-ID-Hash: AC4GGTXT2WLIRD7APFDDCXZO3XVKUDJS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 16 Nov 2022 16:17:13 +1100 David Gibson wrote: > On Tue, Nov 15, 2022 at 02:23:46AM +0100, Stefano Brivio wrote: > > On ia64, clone(2) is not available: the glibc wrapper is named > > __clone2() and it takes, additionally, the size of the stack area > > passed by the caller. > > > > Spotted in Debian's buildd logs. > > > > Signed-off-by: Stefano Brivio > > Urgh, I'd really prefer to make our own wrapper to reduce two ifdefs > to one. Hmm, right. I'd go with: __clone(int (*fn)(void *), void *stack_base, size_t stack_size, int flags, void *arg) ...where stack_base is ns_fn_stack. Better ideas (especially for the name)? -- Stefano