Re: [PATCH 01/32] clang-tidy: Suppress warning about assignments in if statements

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 16 Nov 2022 15:41:41 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> clang-tools 15.0.0 appears to have added a new warning that will always
> complain about assignments in if statements, which we use in a number of
> places in passt/pasta.  Encountered on Fedora 37 with
> clang-tools-extra-15.0.0-3.fc37.x86_64.
> 
> Suppress the new warning so that we can compile and test.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 6b22408..8bcbbc0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -262,6 +262,7 @@ clang-tidy: $(SRCS) $(HEADERS)
>  	clang-tidy -checks=*,-modernize-*,\
>  	-clang-analyzer-valist.Uninitialized,\
>  	-cppcoreguidelines-init-variables,\
> +	-bugprone-assignment-in-if-condition,\

I'm trying to keep, in the comment just above, a list of clang-tidy
warnings we disable and the reason. I think this could just be grouped
with:

# - cppcoreguidelines-init-variables
#	Dubious value, would kill readability

-- 
Stefano