From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 34F665A026A for ; Thu, 17 Nov 2022 06:59:21 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NCTkl3nKdz4xxJ; Thu, 17 Nov 2022 16:59:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668664751; bh=I1uMkv7tr+jg6mCmFs2TBxxb15D1i+NSe0xcRzRiYJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o5c87DsBXhWomN7/ECQWOhqjnM+as2cyuZU8btW3dG6LeN+A/fpV2CvNwkK5Cz1e5 SnZS+P2TegjnZ4nW1CD3O3kTR9I9CxyO4qfiK45F45J0IiGlq1G7AtqgpzL702zmvy B9fXEgczc8N+SIfXxTtO7seEkmrm/yU7oDVFT/mc= From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 20/32] tcp: Hash IPv4 and IPv4-mapped-IPv6 addresses the same Date: Thu, 17 Nov 2022 16:58:56 +1100 Message-Id: <20221117055908.2782981-21-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117055908.2782981-1-david@gibson.dropbear.id.au> References: <20221117055908.2782981-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: KOW623VVBULY2Q73RF7AWMMR2AHD7TD4 X-Message-ID-Hash: KOW623VVBULY2Q73RF7AWMMR2AHD7TD4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In the tcp_conn structure, we represent the address with an inany_addr which could be an IPv4 or IPv6 address. However, we have different paths which will calculate different hashes for IPv4 and equivalent IPv4-mapped IPv6 addresses. This will cause problems for some future changes. Make the hash function work the same for these two cases, by taking an inany_addr directly. Since this represents IPv4 and IPv4-mapped IPv6 addresses the same way, it will trivially hash the same for both cases. Callers are changed to construct an inany_addr from whatever they have. Some of that will be elided in later changes. Signed-off-by: David Gibson --- siphash.c | 1 + tcp.c | 52 ++++++++++++++++++---------------------------------- 2 files changed, 19 insertions(+), 34 deletions(-) diff --git a/siphash.c b/siphash.c index 37a6d73..516a508 100644 --- a/siphash.c +++ b/siphash.c @@ -104,6 +104,7 @@ * * Return: the 64-bit hash output */ +/* cppcheck-suppress unusedFunction */ uint64_t siphash_8b(const uint8_t *in, const uint64_t *k) { PREAMBLE(8); diff --git a/tcp.c b/tcp.c index d1008ae..92dd422 100644 --- a/tcp.c +++ b/tcp.c @@ -1205,8 +1205,7 @@ static int tcp_hash_match(const struct tcp_tap_conn *conn, /** * tcp_hash() - Calculate hash value for connection given address and ports * @c: Execution context - * @af: Address family, AF_INET or AF_INET6 - * @addr: Remote address, pointer to in_addr or in6_addr + * @addr: Remote address * @tap_port: tap-facing port * @sock_port: Socket-facing port * @@ -1215,32 +1214,19 @@ static int tcp_hash_match(const struct tcp_tap_conn *conn, #if TCP_HASH_NOINLINE __attribute__((__noinline__)) /* See comment in Makefile */ #endif -static unsigned int tcp_hash(const struct ctx *c, int af, const void *addr, +static unsigned int tcp_hash(const struct ctx *c, const union inany_addr *addr, in_port_t tap_port, in_port_t sock_port) { + struct { + union inany_addr addr; + in_port_t tap_port; + in_port_t sock_port; + } __attribute__((__packed__)) in = { + *addr, tap_port, sock_port + }; uint64_t b = 0; - if (af == AF_INET) { - struct { - struct in_addr addr; - in_port_t tap_port; - in_port_t sock_port; - } __attribute__((__packed__)) in = { - *(struct in_addr *)addr, tap_port, sock_port, - }; - - b = siphash_8b((uint8_t *)&in, c->tcp.hash_secret); - } else if (af == AF_INET6) { - struct { - struct in6_addr addr; - in_port_t tap_port; - in_port_t sock_port; - } __attribute__((__packed__)) in = { - *(struct in6_addr *)addr, tap_port, sock_port, - }; - - b = siphash_20b((uint8_t *)&in, c->tcp.hash_secret); - } + b = siphash_20b((uint8_t *)&in, c->tcp.hash_secret); return (unsigned int)(b % TCP_HASH_TABLE_SIZE); } @@ -1255,14 +1241,7 @@ static unsigned int tcp_hash(const struct ctx *c, int af, const void *addr, static unsigned int tcp_conn_hash(const struct ctx *c, const struct tcp_tap_conn *conn) { - const struct in_addr *a4 = inany_v4(&conn->addr); - - if (a4) - return tcp_hash(c, AF_INET, a4, - conn->tap_port, conn->sock_port); - else - return tcp_hash(c, AF_INET6, &conn->addr.a6, - conn->tap_port, conn->sock_port); + return tcp_hash(c, &conn->addr, conn->tap_port, conn->sock_port); } /** @@ -1275,9 +1254,11 @@ static unsigned int tcp_conn_hash(const struct ctx *c, static void tcp_hash_insert(const struct ctx *c, struct tcp_tap_conn *conn, int af, const void *addr) { + union inany_addr aany; int b; - b = tcp_hash(c, af, addr, conn->tap_port, conn->sock_port); + inany_from_af(&aany, af, addr); + b = tcp_hash(c, &aany, conn->tap_port, conn->sock_port); conn->next_index = tc_hash[b] ? CONN_IDX(tc_hash[b]) : -1; tc_hash[b] = conn; @@ -1357,9 +1338,12 @@ static struct tcp_tap_conn *tcp_hash_lookup(const struct ctx *c, in_port_t tap_port, in_port_t sock_port) { - int b = tcp_hash(c, af, addr, tap_port, sock_port); + union inany_addr aany; struct tcp_tap_conn *conn; + int b; + inany_from_af(&aany, af, addr); + b = tcp_hash(c, &aany, tap_port, sock_port); for (conn = tc_hash[b]; conn; conn = conn_at_idx(conn->next_index)) { if (tcp_hash_match(conn, af, addr, tap_port, sock_port)) return conn; -- 2.38.1