From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id F16C65A026E for ; Thu, 17 Nov 2022 06:59:16 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NCTkl1ghgz4xZv; Thu, 17 Nov 2022 16:59:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668664751; bh=KRl2Pvm+xJ8fkF8BTSUrKtDdACtup2xB6XWkQgAJC8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=osxe1wcQ44bH66SfILm+FrbzSjhSXiOxjbfYhOfeEJSLOSUmM21GB8M9vrJOgXreN yXZLejEyYr/BWOp83Bz6iFA+JHPU3pEsDuzBoRgj3tO8UVeOx1K5Pv8DqzpFGOUNyb uAkK8vJ7qWQemGCvCoiRP1PQPy756ost/grlC9H0= From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 03/32] tcp_splice: #include tcp_splice.h in tcp_splice.c Date: Thu, 17 Nov 2022 16:58:39 +1100 Message-Id: <20221117055908.2782981-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117055908.2782981-1-david@gibson.dropbear.id.au> References: <20221117055908.2782981-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: C5A2PKZVZEHYYR2ERYXS5PMR65ZCO6ET X-Message-ID-Hash: C5A2PKZVZEHYYR2ERYXS5PMR65ZCO6ET X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This obvious include was omitted, which means that declarations in the header weren't checked against definitions in the .c file. This shows up an old declaration for a function that is now static, and a duplicate #define. Signed-off-by: David Gibson --- tcp_splice.c | 2 +- tcp_splice.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tcp_splice.c b/tcp_splice.c index 99c5fa7..3c5c111 100644 --- a/tcp_splice.c +++ b/tcp_splice.c @@ -49,9 +49,9 @@ #include "util.h" #include "passt.h" #include "log.h" +#include "tcp_splice.h" #define MAX_PIPE_SIZE (8UL * 1024 * 1024) -#define TCP_SPLICE_MAX_CONNS (128 * 1024) #define TCP_SPLICE_PIPE_POOL_SIZE 16 #define TCP_SPLICE_CONN_PRESSURE 30 /* % of splice_conn_count */ #define TCP_SPLICE_FILE_PRESSURE 30 /* % of c->nofile */ diff --git a/tcp_splice.h b/tcp_splice.h index 63ffc68..2c4bff3 100644 --- a/tcp_splice.h +++ b/tcp_splice.h @@ -8,11 +8,8 @@ #define TCP_SPLICE_MAX_CONNS (128 * 1024) -struct tcp_splice_conn; - void tcp_sock_handler_splice(struct ctx *c, union epoll_ref ref, uint32_t events); -void tcp_splice_destroy(struct ctx *c, struct tcp_splice_conn *conn); void tcp_splice_init(struct ctx *c); void tcp_splice_timer(struct ctx *c); void tcp_splice_defer_handler(struct ctx *c); -- 2.38.1