Re: [PATCH v3] util, pasta: Add do_clone() wrapper around __clone2() and clone()

[Stefano Brivio <sbrivio@redhat.com>]

On Thu, 17 Nov 2022 10:00:32 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Nov 16, 2022 at 05:30:57PM +0100, Stefano Brivio wrote:
> > Spotted in Debian's buildd logs: on ia64, clone(2) is not available:
> > the glibc wrapper is named __clone2() and it takes, additionally,
> > the size of the stack area passed by the caller.
> > 
> > Add a do_clone() wrapper handling the different cases, and also
> > taking care of pointing the child's stack in the middle of the
> > allocated area: on PA-RISC (hppa), handled by clone(), the stack
> > grows up, and on ia64 the stack grows down, but the register backing
> > store grows up -- and I think it might be actually used here.
> > 
> > Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> Heh, my only comment on v2 was going to be that it's not a good idea
> to name identifiers starting with _ - that's reserved for the system
> library.

Oops, yes, I keep forgetting about that -- and we already have other
offenders in util.c, I'll try to switch them to other names at some
point.

-- 
Stefano