From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id DE8795A005E for ; Thu, 17 Nov 2022 16:33:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668699216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qPfzVZPp/WO4OYtNs5JSXtvG5kkDmJV3pCTz5xvRovU=; b=Y4Hmx2wwu+naaT1MTBcHzwNL3TOBmsn+SkOveOHqmCSfy0IR82gx62O/fmwmqQwlH00H+2 ChsCbCI5AumUWUfiiXE0UWUB8vxUGjA5zNNrurqGQa0j3m6FUsALXEpg28x/PFMHFP5dLw PeRcAxUOLNE9rtckQW4PjanLlKFBaL8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-uhhg37IbMvifmg_pZrQYJg-1; Thu, 17 Nov 2022 10:33:35 -0500 X-MC-Unique: uhhg37IbMvifmg_pZrQYJg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3CB11181B207 for ; Thu, 17 Nov 2022 15:33:35 +0000 (UTC) Received: from localhost (unknown [10.39.193.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0200E141511E; Thu, 17 Nov 2022 15:33:34 +0000 (UTC) Date: Thu, 17 Nov 2022 15:33:32 +0000 From: "Richard W.M. Jones" To: Stefano Brivio Subject: Re: [PATCH v2 3/5] passt, tap: Add --fd option Message-ID: <20221117153332.GG7636@redhat.com> References: <20221117122614.1269214-4-rjones@redhat.com> <20221117152640.2535159-1-sbrivio@redhat.com> <20221117163105.13dec02e@elisabeth> MIME-Version: 1.0 In-Reply-To: <20221117163105.13dec02e@elisabeth> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Message-ID-Hash: B4OP7M7NB3U5QL245F23GO7NVNIFPEQF X-Message-ID-Hash: B4OP7M7NB3U5QL245F23GO7NVNIFPEQF X-MailFrom: rjones@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Nov 17, 2022 at 04:31:05PM +0100, Stefano Brivio wrote: > On Thu, 17 Nov 2022 16:26:40 +0100 > Stefano Brivio wrote: > > > @@ -1138,9 +1140,9 @@ void conf(struct ctx *c, int argc, char **argv) > > > > if (c->mode == MODE_PASTA) { > > c->no_dhcp_dns = c->no_dhcp_dns_search = 1; > > - optstring = "dqfel:hI:p:P:m:a:n:M:g:i:D:S:46t:u:T:U:"; > > + optstring = "dqfel:hf:I:p:P:m:a:n:M:g:i:D:S:46t:u:T:U:"; > > } else { > > - optstring = "dqfel:hs:p:P:m:a:n:M:g:i:D:S:461t:u:"; > > + optstring = "dqfel:hs:f:p:P:m:a:n:M:g:i:D:S:461t:u:"; > > Should be 'F', really. OK, will update my copy too. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top