From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by passt.top (Postfix) with ESMTP id D3BC75A005E
	for <passt-dev@passt.top>; Thu, 17 Nov 2022 16:31:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1668699070;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yGORgs8wVXTRR+IuKjQxzkv0IVS3hO3iKz4B39QngGg=;
	b=ZAxRoW+v8pCEKIFysFBj9yCzTpVgMn0KPHxQy4yfXr0U9JuUcSu7dOUzGWbqbvqDkOTh+V
	1cz2pcT+yKuVfxiyL5ZqcEDviJvS4HPzvxtEyCcNN/EDoWSPw06yivI434WpATjiVhcr1S
	Lo2TWLwYeQWS9J8vKRUt0ddrEz4x7Po=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-475-Jb0GLOXwMnile82as1O8QQ-1; Thu, 17 Nov 2022 10:31:08 -0500
X-MC-Unique: Jb0GLOXwMnile82as1O8QQ-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EE921871CC9
	for <passt-dev@passt.top>; Thu, 17 Nov 2022 15:31:08 +0000 (UTC)
Received: from maya.cloud.tilaa.com (ovpn-208-8.brq.redhat.com [10.40.208.8])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A76C492B04;
	Thu, 17 Nov 2022 15:31:08 +0000 (UTC)
Date: Thu, 17 Nov 2022 16:31:05 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [PATCH v2 3/5] passt, tap: Add --fd option
Message-ID: <20221117163105.13dec02e@elisabeth>
In-Reply-To: <20221117152640.2535159-1-sbrivio@redhat.com>
References: <20221117122614.1269214-4-rjones@redhat.com>
	<20221117152640.2535159-1-sbrivio@redhat.com>
Organization: Red Hat
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID-Hash: B3Y6PE3IGSHC7QBMRGFVFIHC7ZJJRDAK
X-Message-ID-Hash: B3Y6PE3IGSHC7QBMRGFVFIHC7ZJJRDAK
X-MailFrom: sbrivio@redhat.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top
X-Mailman-Version: 3.3.3
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20221117163105.13dec02e@elisabeth/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/B3Y6PE3IGSHC7QBMRGFVFIHC7ZJJRDAK/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

On Thu, 17 Nov 2022 16:26:40 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> @@ -1138,9 +1140,9 @@ void conf(struct ctx *c, int argc, char **argv)
>  
>  	if (c->mode == MODE_PASTA) {
>  		c->no_dhcp_dns = c->no_dhcp_dns_search = 1;
> -		optstring = "dqfel:hI:p:P:m:a:n:M:g:i:D:S:46t:u:T:U:";
> +		optstring = "dqfel:hf:I:p:P:m:a:n:M:g:i:D:S:46t:u:T:U:";
>  	} else {
> -		optstring = "dqfel:hs:p:P:m:a:n:M:g:i:D:S:461t:u:";
> +		optstring = "dqfel:hs:f:p:P:m:a:n:M:g:i:D:S:461t:u:";

Should be 'F', really.

-- 
Stefano