Re: [PATCH passt 5/5] Import fuzzing wrapper from libnbd

[Stefano Brivio <sbrivio@redhat.com>]

Not an actual review, just two things I noticed while trying this:

On Thu, 17 Nov 2022 12:26:14 +0000
"Richard W.M. Jones" <rjones@redhat.com> wrote:

> diff --git a/fuzzing/README.fuzzing.md b/fuzzing/README.fuzzing.md
> new file mode 100644
> index 0000000..4d86b2f
> --- /dev/null
> +++ b/fuzzing/README.fuzzing.md
> @@ -0,0 +1,36 @@
> +## Fuzzing with AFL++ (https://aflplus.plus/)
> +
> +1. In the top directory rebuild passt with AFL instrumentation, Clang
> +   and ASAN:
> +
> +```
> +make clean
> +AFL_USE_ASAN=1 make CC=/usr/bin/afl-clang-lto passt

I don't have afl-clang-lto, I used afl-clang-fast instead (there's also
afl-clang, not sure which one is the most appropriate).

> [...]
>
> +++ b/fuzzing/fuzz-wrapper.c
> @@ -0,0 +1,173 @@
> +/* Fuzzing wrapper
> + * Derived from libnbd fuzzing wrapper
> + * Copyright (C) 2013-2022 Red Hat Inc.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdbool.h>
> +#include <stdint.h>
> +#include <inttypes.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <unistd.h>
> +#include <poll.h>
> +#include <errno.h>
> +#include <sys/types.h>
> +#include <sys/socket.h>
> +#include <sys/wait.h>
> +
> +#include <libnbd.h>

This can probably be dropped (noticed because I didn't have libnbd-dev
installed).

-- 
Stefano