From: "Richard W.M. Jones" <rjones@redhat.com>
To: sbrivio@redhat.com
Cc: passt-dev@passt.top
Subject: [PATCH passt v2 6/7] XXX passt: Kill seccomp and other isolation mechanisms
Date: Thu, 17 Nov 2022 18:49:37 +0000 [thread overview]
Message-ID: <20221117184938.2270462-7-rjones@redhat.com> (raw)
In-Reply-To: <20221117184938.2270462-1-rjones@redhat.com>
I suspect these interfere in some way with AFL instrumentation. The
instrumented binary deadlocks without this patch, but it's hard to
understand why just looking at strace output.
---
conf.c | 2 +-
passt.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/conf.c b/conf.c
index 9ec346f..fcc5664 100644
--- a/conf.c
+++ b/conf.c
@@ -1655,7 +1655,7 @@ void conf(struct ctx *c, int argc, char **argv)
usage(argv[0]);
}
- isolate_user(uid, gid, !netns_only, userns, c->mode);
+ //isolate_user(uid, gid, !netns_only, userns, c->mode);
if (c->pasta_conf_ns)
c->no_ra = 1;
diff --git a/passt.c b/passt.c
index 8b2c50d..2a4e65a 100644
--- a/passt.c
+++ b/passt.c
@@ -185,7 +185,7 @@ int main(int argc, char **argv)
arch_avx2_exec(argv);
- isolate_initial();
+ //isolate_initial();
c.pasta_netns_fd = c.fd_tap = c.fd_tap_listen = -1;
@@ -291,17 +291,19 @@ int main(int argc, char **argv)
}
}
+#if 0
if (isolate_prefork(&c)) {
err("Failed to sandbox process, exiting\n");
exit(EXIT_FAILURE);
}
+#endif
if (!c.foreground)
__daemon(pidfile_fd, devnull_fd);
else
write_pidfile(pidfile_fd, getpid());
- isolate_postfork(&c);
+ //isolate_postfork(&c);
timer_init(&c, &now);
--
@@ -185,7 +185,7 @@ int main(int argc, char **argv)
arch_avx2_exec(argv);
- isolate_initial();
+ //isolate_initial();
c.pasta_netns_fd = c.fd_tap = c.fd_tap_listen = -1;
@@ -291,17 +291,19 @@ int main(int argc, char **argv)
}
}
+#if 0
if (isolate_prefork(&c)) {
err("Failed to sandbox process, exiting\n");
exit(EXIT_FAILURE);
}
+#endif
if (!c.foreground)
__daemon(pidfile_fd, devnull_fd);
else
write_pidfile(pidfile_fd, getpid());
- isolate_postfork(&c);
+ //isolate_postfork(&c);
timer_init(&c, &now);
--
2.37.0.rc2
next prev parent reply other threads:[~2022-11-17 18:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:49 [PATCH passt v2 0/7] Add fuzzing Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 1/7] build: Force-create pasta symlink Richard W.M. Jones
2022-11-18 1:30 ` David Gibson
2022-11-18 7:56 ` Stefano Brivio
2022-11-17 18:49 ` [PATCH passt v2 2/7] build: Remove *~ files with make clean Richard W.M. Jones
2022-11-18 1:31 ` David Gibson
2022-11-17 18:49 ` [PATCH passt v2 3/7] passt, tap: Add --fd option Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 4/7] passt, tap: Process data on the socket before HUP/ERR events Richard W.M. Jones
2022-11-18 1:32 ` David Gibson
2022-11-17 18:49 ` [PATCH passt v2 5/7] XXX build: Add extra syscalls needed by AFL instrumentation Richard W.M. Jones
2022-11-17 18:49 ` Richard W.M. Jones [this message]
2022-11-17 18:49 ` [PATCH passt v2 7/7] Import fuzzing wrapper from libnbd Richard W.M. Jones
2022-11-17 19:06 ` [PATCH passt v2 0/7] Add fuzzing Richard W.M. Jones
2022-11-18 10:12 ` Richard W.M. Jones
2022-11-25 9:23 ` Stefano Brivio
2022-11-25 10:11 ` Richard W.M. Jones
2022-11-29 13:34 ` Stefano Brivio
2022-11-29 13:44 ` Richard W.M. Jones
2022-11-30 1:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117184938.2270462-7-rjones@redhat.com \
--to=rjones@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).