From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 877D45A0275 for ; Thu, 17 Nov 2022 19:49:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668710988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ckIftBqUohMySaTMfBC/lsEEMd9vhTQLgp9E/1M9cc=; b=G2+iTlIyAUNlKFQK83PS4tsfAcpM6vGz71bQVUdWsaBtdH5UNXzRiLoMPvmf0bkxMf/JIi vn3G3fpnmSIRh159nMGrcxabD3lvBun3Dc889PCGbIxgN8kgbcmAF+CQC+WGY9YgAjacTG k6y8fcYpA6Kbi62aLZQf62S64xzLBN8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-48-Dkdks_MbOlOmjHCSn84Kkg-1; Thu, 17 Nov 2022 13:49:47 -0500 X-MC-Unique: Dkdks_MbOlOmjHCSn84Kkg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE5E485A59D for ; Thu, 17 Nov 2022 18:49:46 +0000 (UTC) Received: from pick.home.annexia.org (unknown [10.39.193.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78E1E40C6EC3; Thu, 17 Nov 2022 18:49:46 +0000 (UTC) From: "Richard W.M. Jones" To: sbrivio@redhat.com Subject: [PATCH passt v2 6/7] XXX passt: Kill seccomp and other isolation mechanisms Date: Thu, 17 Nov 2022 18:49:37 +0000 Message-Id: <20221117184938.2270462-7-rjones@redhat.com> In-Reply-To: <20221117184938.2270462-1-rjones@redhat.com> References: <20221117184938.2270462-1-rjones@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: 4N24XNDOFYFERMOLAKGPUHVJ3J6WHLZR X-Message-ID-Hash: 4N24XNDOFYFERMOLAKGPUHVJ3J6WHLZR X-MailFrom: rjones@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I suspect these interfere in some way with AFL instrumentation. The instrumented binary deadlocks without this patch, but it's hard to understand why just looking at strace output. --- conf.c | 2 +- passt.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/conf.c b/conf.c index 9ec346f..fcc5664 100644 --- a/conf.c +++ b/conf.c @@ -1655,7 +1655,7 @@ void conf(struct ctx *c, int argc, char **argv) usage(argv[0]); } - isolate_user(uid, gid, !netns_only, userns, c->mode); + //isolate_user(uid, gid, !netns_only, userns, c->mode); if (c->pasta_conf_ns) c->no_ra = 1; diff --git a/passt.c b/passt.c index 8b2c50d..2a4e65a 100644 --- a/passt.c +++ b/passt.c @@ -185,7 +185,7 @@ int main(int argc, char **argv) arch_avx2_exec(argv); - isolate_initial(); + //isolate_initial(); c.pasta_netns_fd = c.fd_tap = c.fd_tap_listen = -1; @@ -291,17 +291,19 @@ int main(int argc, char **argv) } } +#if 0 if (isolate_prefork(&c)) { err("Failed to sandbox process, exiting\n"); exit(EXIT_FAILURE); } +#endif if (!c.foreground) __daemon(pidfile_fd, devnull_fd); else write_pidfile(pidfile_fd, getpid()); - isolate_postfork(&c); + //isolate_postfork(&c); timer_init(&c, &now); -- 2.37.0.rc2