From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 151F15A005E for ; Thu, 17 Nov 2022 20:06:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668711976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PERd6UyJN60aDATPurxcz/rXskHy9rKO4ZdoTvJLAR4=; b=KcdTV+pEopxrKrNgoLBYsrXsMYL9ZFy80AIaoedm4ZCQ1hzqXkuAgChSjCURiTqtsXvMIZ jp+/8JfE07PedDAojdr07DFUTDSX8wtjA64HA2m3Wxp2TNdHeKg9/knY5N9/0PLWjB5vXX aObEGSpcUrI+YHLT4jEC7ngJoltUUKo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-371-mW6WnCCZMFCDIPH9Dcd6uQ-1; Thu, 17 Nov 2022 14:06:15 -0500 X-MC-Unique: mW6WnCCZMFCDIPH9Dcd6uQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B9093806652 for ; Thu, 17 Nov 2022 19:06:15 +0000 (UTC) Received: from localhost (unknown [10.39.193.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id ACEE635429; Thu, 17 Nov 2022 19:06:14 +0000 (UTC) Date: Thu, 17 Nov 2022 19:06:12 +0000 From: "Richard W.M. Jones" To: sbrivio@redhat.com Subject: Re: [PATCH passt v2 0/7] Add fuzzing Message-ID: <20221117190612.GB30956@redhat.com> References: <20221117184938.2270462-1-rjones@redhat.com> MIME-Version: 1.0 In-Reply-To: <20221117184938.2270462-1-rjones@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Message-ID-Hash: GHZOGQVZQAXPADXZRONJWRS3HRWDNAZS X-Message-ID-Hash: GHZOGQVZQAXPADXZRONJWRS3HRWDNAZS X-MailFrom: rjones@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I forgot to mention that I didn't sort out test cases yet. The current test case (single zero length packet) is not ideal. We might have a single test case, say a single TCP SYN packet. However if there are distinct areas of functionality in passt (eg. TCP connect, ARP, DNS, DHCP, ...), *and* if those are geometrically very far apart in the search space, then you could argue for having one test case per major feature. Capturing that into tap files will be a fun afternoon for someone. More on this topic here: https://aflplus.plus/docs/fuzzing_in_depth/#2-preparing-the-fuzzing-campaign - - - Also ... while we do have --fd functionality, even better would be to modify passt so it can read input from stdin and drop output. See: https://aflplus.plus/docs/best_practices/#fuzzing-a-network-service The socketpair / --fd approach is a bit cleaner. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top