From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C04335A0082 for ; Fri, 18 Nov 2022 08:56:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668758184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNhqhrZwfjaxTNbDoAi1lInz6+UeQDGnenoVpbxOcNw=; b=doQS4WYxWHKxzBzh+xcb9TVlAIcxtPBO3cQCH0WhW+uQ8bFekUk34D8mWtI1lHSqZJWsLs jpsNToii8xkr8soI5n0WsT7kOldx/VQsnKt54FxzXH4tpExsDcIBD9PhihUmMLkhBNRHXa fWg93G1Es+IQgW5CrptwTTcS4IMEwN4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647--khNrHk5Nb2OgXNVqXhOYw-1; Fri, 18 Nov 2022 02:56:23 -0500 X-MC-Unique: -khNrHk5Nb2OgXNVqXhOYw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC0B6185A78B; Fri, 18 Nov 2022 07:56:22 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-8.brq.redhat.com [10.40.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6226F2166B29; Fri, 18 Nov 2022 07:56:22 +0000 (UTC) Date: Fri, 18 Nov 2022 08:56:19 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH passt v2 1/7] build: Force-create pasta symlink Message-ID: <20221118085619.31b70c64@elisabeth> In-Reply-To: References: <20221117184938.2270462-1-rjones@redhat.com> <20221117184938.2270462-2-rjones@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 5I5WB7RVSBVVXDD5J7NIRTW72RLTO2MJ X-Message-ID-Hash: 5I5WB7RVSBVVXDD5J7NIRTW72RLTO2MJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "Richard W.M. Jones" , passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 18 Nov 2022 12:30:25 +1100 David Gibson wrote: > On Thu, Nov 17, 2022 at 06:49:32PM +0000, Richard W.M. Jones wrote: > > If you run the build several times it will fail unnecessarily with: > > > > ln -s passt pasta > > ln: failed to create symbolic link 'pasta': File exists > > make: *** [Makefile:134: pasta] Error 1 > > > > Signed-off-by: Richard W.M. Jones > > Reviewed-by: David Gibson > > I'm not sure why I haven't hit that before. I'm also a bit puzzled: after all, if 'pasta' exists, the 'pasta' target is up to date. Then I hit this while doing stuff on Debian packages, I don't remember what the exact sequence was. Well, in any case, it looks reasonable. -- Stefano