From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 2F8EF5A0082 for ; Tue, 22 Nov 2022 22:51:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669153910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fQ2nWapyNeJevyZHZdTMGHQIp4BusiTmy+11+gEZkI=; b=ULtT5G02l+YoH1EuXh2okAVY89n9xfA0KiHMpTI07aahvunVr0gi9wefJk6Uc9FHpHj1kZ by4wdeERm6z5vwP/GQ3IpbdTzBfJHKkIB4Y20sZomeUH37i+280Ua7/hTC+NyLoWF4kI6V OLpQgNEdvmU6gnjlYFnA0W1BrKm78L0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-RxdQP_j7PS-EVvxYvNVcUQ-1; Tue, 22 Nov 2022 16:51:47 -0500 X-MC-Unique: RxdQP_j7PS-EVvxYvNVcUQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C5F487B2A0; Tue, 22 Nov 2022 21:51:47 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-30.brq.redhat.com [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7184492B17; Tue, 22 Nov 2022 21:51:46 +0000 (UTC) Date: Tue, 22 Nov 2022 22:51:43 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 00/11] Simplify handling of "spliced" UDP forwarding Message-ID: <20221122225143.4f3d630e@elisabeth> In-Reply-To: <20221122034402.1517544-1-david@gibson.dropbear.id.au> References: <20221122034402.1517544-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BVWPFIMEWWSTKKBTFP24LJIFRRS3OYM5 X-Message-ID-Hash: BVWPFIMEWWSTKKBTFP24LJIFRRS3OYM5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 22 Nov 2022 14:43:51 +1100 David Gibson wrote: > This series make some substantial simplifications to how we handle the > forwarding of "spliced" UDP packets (those that don't go over the > tuntap device, but instead are forwarded from one L4 socket to > another). > > This doesn't yet change the existing (arguably broken) assumption that > UDP communications are from one port to one port within the pasta > namespace, not one to many or many to one. However, the > simplifications made here will make it easier to correct that in > future. I'm not done reviewing this yet, but it all makes sense to me -- I just need a bit longer to convince myself of 1/10 to 3/10 despite the fact they're obviously simpler than the original implementation (i.e. of why I didn't implement it like that in the first place ;)). -- Stefano