From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E2D555A0082 for ; Fri, 25 Nov 2022 02:48:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669340886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lxERU4jIxTJV7lMglOoNM8z3DRJRyHxbQ2ShEu5clXA=; b=KZHvEVncqLA1rrBpzCxO2FfBqGFJ4ordP2ZqcWlFo3kRSXAFSnk+8iv/EkArxZLQ69awG3 /2Fae6ztotOVkh1GMXFx81iavr+FtL0s4cRpJokxWeDzYLNOgj5jv/2epDsCaTth8uLsdY mdZpBHSSO4Wn/+AoF+6IZtPMc+DkXn8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-580-nZymyElcM6CIZFppbA8k3g-1; Thu, 24 Nov 2022 20:48:03 -0500 X-MC-Unique: nZymyElcM6CIZFppbA8k3g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C13C3801585; Fri, 25 Nov 2022 01:48:02 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-30.brq.redhat.com [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 657714B3FC6; Fri, 25 Nov 2022 01:48:02 +0000 (UTC) Date: Fri, 25 Nov 2022 02:47:59 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 04/16] udp: Don't connect "forward" sockets for spliced flows Message-ID: <20221125024759.5405714d@elisabeth> In-Reply-To: <20221124011659.1024901-5-david@gibson.dropbear.id.au> References: <20221124011659.1024901-1-david@gibson.dropbear.id.au> <20221124011659.1024901-5-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BKZTEFSUD73KVPWGY5HO5B5VIOKPCCPO X-Message-ID-Hash: BKZTEFSUD73KVPWGY5HO5B5VIOKPCCPO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nit: On Thu, 24 Nov 2022 12:16:47 +1100 David Gibson wrote: > Currently we connect() the socket we use to forward spliced UDP flows. > However, we now only ever use sendto() rather than send() on this socket > so there's not actually any need to connect it. Don't do so. > > Rename a number of things that referred to "connect" or "conn" since that > would now be misleading. > > Signed-off-by: David Gibson > --- > udp.c | 85 ++++++++++++++++++++++++----------------------------------- > 1 file changed, 35 insertions(+), 50 deletions(-) > > diff --git a/udp.c b/udp.c > index 1e78da5..ed095ec 100644 > --- a/udp.c > +++ b/udp.c > @@ -45,23 +45,20 @@ > * > * - from init to namespace: > * > - * - forward direction: 127.0.0.1:5000 -> 127.0.0.1:80 in init from bound > - * socket s, with epoll reference: index = 80, splice = UDP_TO_NS > + * - forward direction: 127.0.0.1:5000 -> 127.0.0.1:80 in init from socket s, > + * with epoll reference: index = 80, splice = UDP_TO_NS > * - if udp_splice_to_ns[V4][5000].target_sock: > * - send packet to udp_splice_to_ns[V4][5000].target_sock, with > * destination port 80 > * - otherwise: > * - create new socket udp_splice_to_ns[V4][5000].target_sock > * - bind in namespace to 127.0.0.1:5000 > - * - connect in namespace to 127.0.0.1:80 (note: this destination port > - * might be remapped to another port instead) > * - add to epoll with reference: index = 5000, splice: UDP_BACK_TO_INIT > * - set udp_splice_to_ns[V4][5000].orig_sock to s > * - update udp_splice_to_ns[V4][5000].ts with current time > * > - * - reverse direction: 127.0.0.1:80 -> 127.0.0.1:5000 in namespace from > - * connected socket s, having epoll reference: index = 5000, > - * splice = UDP_BACK_TO_INIT > + * - reverse direction: 127.0.0.1:80 -> 127.0.0.1:5000 in namespace socket s, > + * having epoll reference: index = 5000, splice = UDP_BACK_TO_INIT > * - if udp_splice_to_ns[V4][5000].orig_sock: > * - send to udp_splice_to_ns[V4][5000].orig_sock, with destination port > * 5000 > @@ -69,7 +66,7 @@ > * > * - from namespace to init: > * > - * - forward direction: 127.0.0.1:2000 -> 127.0.0.1:22 in namespace from bound > + * - forward direction: 127.0.0.1:2000 -> 127.0.0.1:22 in namespace from > * socket s, with epoll reference: index = 22, splice = UDP_TO_INIT > * - if udp4_splice_to_init[V4][2000].target_sock: > * - send packet to udp_splice_to_init[V4][2000].target_sock, with > @@ -77,14 +74,12 @@ > * - otherwise: > * - create new socket udp_splice_to_init[V4][2000].target_sock > * - bind in init to 127.0.0.1:2000 > - * - connect in init to 127.0.0.1:22 (note: this destination port > - * might be remapped to another port instead) > * - add to epoll with reference: index = 2000, splice = UDP_BACK_TO_NS > * - set udp_splice_to_init[V4][2000].orig_sock to s > * - update udp_splice_to_init[V4][2000].ts with current time > * > - * - reverse direction: 127.0.0.1:22 -> 127.0.0.1:2000 in init from connected > - * socket s, having epoll reference: index = 2000, splice = UDP_BACK_TO_NS > + * - reverse direction: 127.0.0.1:22 -> 127.0.0.1:2000 in init from socket s, > + * having epoll reference: index = 2000, splice = UDP_BACK_TO_NS > * - if udp_splice_to_init[V4][2000].orig_sock: > * - send to udp_splice_to_init[V4][2000].orig_sock, with destination port > * 2000 > @@ -144,8 +139,7 @@ struct udp_tap_port { > * @orig_sock: Originating socket, bound to dest port in source ns of > * originating datagram > * @target_sock: Target socket, bound to source port of originating > - * datagram in dest ns, connected to dest port of > - * originating datagram in dest ns > + * datagram in dest ns > * @ts: Activity timestamp > */ > struct udp_splice_flow { > @@ -163,8 +157,8 @@ static struct udp_splice_flow udp_splice_to_init[IP_VERSIONS][NUM_PORTS]; > > enum udp_act_type { > UDP_ACT_TAP, > - UDP_ACT_NS_CONN, > - UDP_ACT_INIT_CONN, > + UDP_ACT_SPLICE_NS, > + UDP_ACT_SPLICE_INIT, > UDP_ACT_TYPE_MAX, > }; > > @@ -398,20 +392,19 @@ static void udp_sock6_iov_init(void) > } > > /** > - * udp_splice_connect() - Create and connect socket for "spliced" binding > + * udp_splice_new() - Create and prepare socket for "spliced" binding > * @c: Execution context > - * @v6: Set for IPv6 connections > + * @v6: Set for IPv6 sockets > * @bound_sock: Originating bound socket > * @src: Source port of original connection, host order > - * @dst: Destination port of original connection, host order > * @splice: UDP_BACK_TO_INIT from init, UDP_BACK_TO_NS from namespace > * > - * Return: connected socket, negative error code on failure > + * Return: Prepared socket, negative error code on failure prepared -- Stefano