From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures
Date: Fri, 25 Nov 2022 03:01:21 +0100 [thread overview]
Message-ID: <20221125030121.760ff153@elisabeth> (raw)
In-Reply-To: <20221124085421.3027886-1-david@gibson.dropbear.id.au>
On Thu, 24 Nov 2022 19:54:17 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> It turns out a couple of places on the IPv4 specific inbound path
> accidentally use control structures that are supposed to be for IPv6.
> That could lead to weird behaviour in a rather complex set of
> circumstances.
Whoops, this is embarrassing.
> Path 1/4 here is the actual fix, the rest makes some clean ups to the
> code that should make similar mistakes harder errors harder to commit
> in future.
The whole series looks good to me.
> This is based on my earlier cleanup of the UDP splicing code, although
> I think it will rebase trivially.
I tried, it does, but I wouldn't needlessly rebase that one on top of
this, I'd rather wait a bit and apply them in order.
--
Stefano
next prev parent reply other threads:[~2022-11-25 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 8:54 [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures David Gibson
2022-11-24 8:54 ` [PATCH 1/4] udp: Fix inorrect use of IPv6 mh buffers in IPv4 path David Gibson
2022-11-24 8:54 ` [PATCH 2/4] udp: Better factor IPv4 and IPv6 paths in udp_sock_handler() David Gibson
2022-11-24 8:54 ` [PATCH 3/4] udp: Preadjust udp[46]_l2_iov_tap[].iov_base for pasta mode David Gibson
2022-11-24 8:54 ` [PATCH 4/4] udp: Factor out control structure management from udp_sock_fill_data_v[46] David Gibson
2022-11-25 2:01 ` Stefano Brivio [this message]
2022-11-25 7:11 ` [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures David Gibson
2022-12-06 6:47 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125030121.760ff153@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).