From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id D926F5A0082 for ; Fri, 25 Nov 2022 03:01:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669341708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVw+U+JFTM0/iumOjtF2aVRc4YldKsWPr8NECFZ2yz8=; b=QagT3RAbANWPMmkrqgJi7g7HUfWDe5nCvMhURNXjpLQJKlsqPaeTyvXFy6RAhze906PV0P Ff6buaZXQwy2KjSI1OHxOse8r5LiK12+r0Cte5RhjvYalvfa2VGJ6MjrGpyxNOZIZ2wKy6 nCvRQ0zqDv6vWSahVCJM3rm/NxOUK+Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-14-Zyb7Wd_LOemqjI9Y2okeWg-1; Thu, 24 Nov 2022 21:01:47 -0500 X-MC-Unique: Zyb7Wd_LOemqjI9Y2okeWg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0238F299E75E; Fri, 25 Nov 2022 02:01:47 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-30.brq.redhat.com [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3C77111E3EB; Fri, 25 Nov 2022 02:01:46 +0000 (UTC) Date: Fri, 25 Nov 2022 03:01:21 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures Message-ID: <20221125030121.760ff153@elisabeth> In-Reply-To: <20221124085421.3027886-1-david@gibson.dropbear.id.au> References: <20221124085421.3027886-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RGJVQYTCQZDREJ7O76N4V273GEKQGB4C X-Message-ID-Hash: RGJVQYTCQZDREJ7O76N4V273GEKQGB4C X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 24 Nov 2022 19:54:17 +1100 David Gibson wrote: > It turns out a couple of places on the IPv4 specific inbound path > accidentally use control structures that are supposed to be for IPv6. > That could lead to weird behaviour in a rather complex set of > circumstances. Whoops, this is embarrassing. > Path 1/4 here is the actual fix, the rest makes some clean ups to the > code that should make similar mistakes harder errors harder to commit > in future. The whole series looks good to me. > This is based on my earlier cleanup of the UDP splicing code, although > I think it will rebase trivially. I tried, it does, but I wouldn't needlessly rebase that one on top of this, I'd rather wait a bit and apply them in order. -- Stefano