From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 900D45A0082 for ; Tue, 6 Dec 2022 07:47:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670309234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X22w+kZwUzRYzdqA1fmSfsG7Q5MjL3/dBIZ6xvnNnh8=; b=XLpve7jMjytSBYnS5w+8D+GadQNSa//skuBpIVdHcGJSBlsJGsBEjtPQyC/Zvdo+rEe7M4 /59ohLRXzdvV2pGX4XuqwCXoSaV8d0PV+TXybiG8WjNjNwXb9fSRUyOQoftK02HNxYv8pl x0q24qzq4CrbU4yiFr8B5O2c9NJmHWc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-194-CLbjuaoGOT6IAR9XnxnknQ-1; Tue, 06 Dec 2022 01:47:09 -0500 X-MC-Unique: CLbjuaoGOT6IAR9XnxnknQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84477833AEF; Tue, 6 Dec 2022 06:47:09 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A7491121325; Tue, 6 Dec 2022 06:47:09 +0000 (UTC) Date: Tue, 6 Dec 2022 07:47:06 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures Message-ID: <20221206074706.383ce0ca@elisabeth> In-Reply-To: <20221124085421.3027886-1-david@gibson.dropbear.id.au> References: <20221124085421.3027886-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VYI7RQ67D7SNTIQDYKRKMPH422BE4KPF X-Message-ID-Hash: VYI7RQ67D7SNTIQDYKRKMPH422BE4KPF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 24 Nov 2022 19:54:17 +1100 David Gibson wrote: > It turns out a couple of places on the IPv4 specific inbound path > accidentally use control structures that are supposed to be for IPv6. > That could lead to weird behaviour in a rather complex set of > circumstances. > > Path 1/4 here is the actual fix, the rest makes some clean ups to the > code that should make similar mistakes harder errors harder to commit > in future. > > This is based on my earlier cleanup of the UDP splicing code, although > I think it will rebase trivially. Applied and pushed. -- Stefano