From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/18] RFC: Unify and simplify tap send path
Date: Fri, 9 Dec 2022 16:42:10 +1100 [thread overview]
Message-ID: <20221209054228.4085990-1-david@gibson.dropbear.id.au> (raw)
Although we have an abstraction for the "slow path" (DHCP, NDP) guest
bound packets, the TCP and UDP forwarding paths write directly to the
tap fd. However, it turns out how they send frames to the tap device
is more similar than it originally appears.
This series unifies the low-level tap send functions for TCP and UDP,
and makes some clean ups along the way.
This is based on my earlier outstanding series.
Changes since v1:
* Abstract tap header construction as well as frame send (a number of
new patches)
* Remove unneeded flags buf_bytes globals as well
* Fix bug where we weren't correctly setting iov_len after the move
to giving variable sized iovecs to send_frames().
David Gibson (18):
pcap: Introduce pcap_frame() helper
pcap: Replace pcapm() with pcap_multiple()
tcp: Combine two parts of passt tap send path together
tcp: Don't keep compute total bytes in a message until we need it
tcp: Improve interface to tcp_l2_buf_flush()
tcp: Combine two parts of pasta tap send path together
tap, tcp: Move tap send path to tap.c
util: Introduce hton*_constant() in place of #ifdefs
tcp, udp: Use named field initializers in iov_init functions
util: Parameterize ethernet header initializer macro
tcp: Remove redundant and incorrect initialization from *_iov_init()
tcp: Consolidate calculation of total frame size
tap: Add "tap headers" abstraction
tcp: Use abstracted tap header
tap: Use different io vector bases depending on tap type
udp: Use abstracted tap header
udp: Use tap_send_frames()
tap: Improve handling of partial frame sends
dhcpv6.c | 50 +++--------
pcap.c | 78 +++++------------
pcap.h | 3 +-
tap.c | 123 +++++++++++++++++++++++++++
tap.h | 54 ++++++++++++
tcp.c | 254 +++++++++++++------------------------------------------
udp.c | 213 ++++++----------------------------------------
udp.h | 2 +-
util.h | 47 ++--------
9 files changed, 303 insertions(+), 521 deletions(-)
--
2.38.1
next reply other threads:[~2022-12-09 5:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 5:42 David Gibson [this message]
2022-12-09 5:42 ` [PATCH v2 01/18] pcap: Introduce pcap_frame() helper David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:47 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 02/18] pcap: Replace pcapm() with pcap_multiple() David Gibson
2022-12-09 5:42 ` [PATCH v2 03/18] tcp: Combine two parts of passt tap send path together David Gibson
2022-12-09 5:42 ` [PATCH v2 04/18] tcp: Don't keep compute total bytes in a message until we need it David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:48 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 05/18] tcp: Improve interface to tcp_l2_buf_flush() David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:53 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 06/18] tcp: Combine two parts of pasta tap send path together David Gibson
2022-12-09 5:42 ` [PATCH v2 07/18] tap, tcp: Move tap send path to tap.c David Gibson
2022-12-09 5:42 ` [PATCH v2 08/18] util: Introduce hton*_constant() in place of #ifdefs David Gibson
2022-12-09 5:42 ` [PATCH v2 09/18] tcp, udp: Use named field initializers in iov_init functions David Gibson
2022-12-09 5:42 ` [PATCH v2 10/18] util: Parameterize ethernet header initializer macro David Gibson
2022-12-09 5:42 ` [PATCH v2 11/18] tcp: Remove redundant and incorrect initialization from *_iov_init() David Gibson
2022-12-09 5:42 ` [PATCH v2 12/18] tcp: Consolidate calculation of total frame size David Gibson
2022-12-09 5:42 ` [PATCH v2 13/18] tap: Add "tap headers" abstraction David Gibson
2022-12-09 5:42 ` [PATCH v2 14/18] tcp: Use abstracted tap header David Gibson
2022-12-09 5:42 ` [PATCH v2 15/18] tap: Use different io vector bases depending on tap type David Gibson
2022-12-09 5:42 ` [PATCH v2 16/18] udp: Use abstracted tap header David Gibson
2022-12-09 5:42 ` [PATCH v2 17/18] udp: Use tap_send_frames() David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:54 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 18/18] tap: Improve handling of partial frame sends David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:57 ` David Gibson
2023-01-04 17:45 ` [PATCH v2 00/18] RFC: Unify and simplify tap send path Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209054228.4085990-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).